Skip to content
This repository has been archived by the owner on Feb 5, 2020. It is now read-only.

Use Availability Set for masters and workers #1043

Merged

Conversation

discordianfish
Copy link
Contributor

Instances in a Scale Set are not supported by the kubernetes
cloud-provider integration.

This closes #93

@coreosbot
Copy link

Can one of the admins verify this patch?

1 similar comment
@coreosbot
Copy link

Can one of the admins verify this patch?

@alexsomesan
Copy link
Contributor

@discordianfish
Thanks for the contribution.
Coincidentally, we have a similar change in the works. However, we planned it to be a bit different.

We're aiming to have alternative implementations for ScaleSets and AvailabilitySets. Because of the current limitations with ScaleSets, the plan is to default to using ASes for as long as necessary and then flip back to ScaleSets once they get the necessary features to work well with K8S.

Would you mind reworking your change to make these a new pair of modules, called modules/azure/master-as and modules/azure/worker-as and rename the existing ones to be prefixed with -ss?

Instances in a Scale Set are not supported by the kubernetes
cloud-provider integration.

This closes coreos#93
@discordianfish
Copy link
Contributor Author

@alexsomesan Like this?
Feel free to pick up my changes and adjust them as you see fit, I won't be able to get back as this in the next days.

@alexsomesan
Copy link
Contributor

Yep, that's what I meant.
Thanks a lot! 👍

I will bring this in and adjust it myself when necessary.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants