Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overrides: fast-track Ignition 2.11.0-2.fc34 #1096

Merged
merged 1 commit into from
Jul 9, 2021
Merged

overrides: fast-track Ignition 2.11.0-2.fc34 #1096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions manifest-lock.overrides.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,3 +24,7 @@ packages:
type: fast-track
reason: https://github.com/coreos/fedora-coreos-config/pull/1088
bodhi: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9d4c3ddc8a
ignition:
evr: 2.11.0-2.fc34
metadata:
type: fast-track
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need the bodhi URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed fast-tracks without the URL before, following the instructions in the comment block. Is there a general preference here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot doesn't need it. It's purely for humans. I personally put it so that it's easy for reviewers to tell that it exists and we won't carry it forever. In this instance, I just manually checked myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, cool. If we generally want it, should we update the header comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that would be nice. I do find the bodhi URL really useful especially when tracking the status manually. i.e. "we've been waiting more than a week for this thing to filter into the stable repos, what's the holdup?" then you check and see the update has negative feedback or something and we need to reconsider our stance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1098