Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overrides: fast-track Ignition 2.11.0-2.fc34 #1096

Merged
merged 1 commit into from
Jul 9, 2021
Merged

overrides: fast-track Ignition 2.11.0-2.fc34 #1096

merged 1 commit into from
Jul 9, 2021

Conversation

bgilbert
Copy link
Contributor

@bgilbert bgilbert commented Jul 9, 2021

Move ignition-firstboot-complete and ignition-setup-user services to fedora-coreos-config.

Move ignition-firstboot-complete and ignition-setup-user services to
fedora-coreos-config.
ignition:
evr: 2.11.0-2.fc34
metadata:
type: fast-track
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we not need the bodhi URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed fast-tracks without the URL before, following the instructions in the comment block. Is there a general preference here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bot doesn't need it. It's purely for humans. I personally put it so that it's easy for reviewers to tell that it exists and we won't carry it forever. In this instance, I just manually checked myself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, cool. If we generally want it, should we update the header comment?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that would be nice. I do find the bodhi URL really useful especially when tracking the status manually. i.e. "we've been waiting more than a week for this thing to filter into the stable repos, what's the holdup?" then you check and see the update has negative feedback or something and we need to reconsider our stance.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bgilbert bgilbert merged commit 0954cfb into coreos:testing-devel Jul 9, 2021
@bgilbert bgilbert deleted the ignition/testing-devel branch July 9, 2021 19:20
dustymabe pushed a commit that referenced this pull request Jul 13, 2021
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this pull request Oct 10, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants