-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 3.1.0 #175
Release 3.1.0 #175
Conversation
This bumps version minor component, after the introduction of a new feature (boot check-in).
/cc @jlebon for a green stamp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM! |
LGTM |
So, this needs a final piece here for RHCOS/FCOS, which is the actual systemd unit that will replace the phone home service on CL. Should we include it in this repo? |
My ideal case, which may be mis-informed, is that once this update goes in, provided azure is identified as the oem id on the kernel command line, all the needfuls will happen on a *COS system to keep in online in Azure. Likewise for packet. If that means including the unit file, then I think my answer is yes. |
I agree. |
Yeah, definitely no doubt we need a systemd unit somewhere. My question was more about where. :) It'd be nice to keep it here, but I'd like to confirm the interactions with CL since we probably don't want to change how check-in works there at this point. (Or do we?) |
@jlebon I think that the service file could live here (next to the existing one). However I think that right now it is quicker to tag this, add the unit via RPM packaging, test everything and then move the unit to here once everything is confirmed ok. If no objections, I'll proceed with the release. |
Sure, WFM! |
coreos-metadata 3.1.0: