Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: add boot check-in on azure and packet #147

Merged
merged 5 commits into from
Mar 5, 2019
Merged

provider: add boot check-in on azure and packet #147

merged 5 commits into from
Mar 5, 2019

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Jan 14, 2019

This is a respin of #130. So far it's mostly #130 rebased on top of #145 + minor fixes squashed in. A basic test in Azure works, though I'd like to test it some more. No testing done on Packet yet.

@jlebon jlebon changed the title WIP: provider: add boot check-in on azure and packet provider: add boot check-in on azure and packet Feb 21, 2019
lucab and others added 5 commits February 21, 2019 16:54
This adds a phone-home feature via the `--check-in` flag, in order to
support reporting back readiness state to the hosting infrastructure.
Initial implementation supports azure and packet.
There's no need for GET requests to have a Content-Type header since
it's only useful as a way to interpret the message body, which by
definition GET requests do not have.
A POST request doesn't have to have a body. Make the `body` argument an
`Option` to reflect that.
First, we were incorrectly building the `/events` URL. But second,
POSTing a "succeeded" message is not a substitute for phoning home; we
still need to do that. In which case, there's no need to POST to
`/events` also. So let's just simplify things and do a POST only to
`/phone-home`, just like `packet-phone-home.service`.
The MIME type for JSON is `application/json`, not `text/json`. Packet
was choking on this as a result.
@jlebon
Copy link
Member Author

jlebon commented Feb 21, 2019

OK, this is now tested working on both Packet and Azure. ✔️
Dropping WIP!

src/retry/client.rs Show resolved Hide resolved
src/retry/client.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@lucab
Copy link
Contributor

lucab commented Mar 5, 2019

@jlebon LGTM, thanks for catching my mistakes! Any last minute thing before I merge this?

@jlebon
Copy link
Member Author

jlebon commented Mar 5, 2019

Nope, this is good to go!

@lucab lucab merged commit 0ccef66 into coreos:master Mar 5, 2019
@mrguitar
Copy link

@lucab This is significant enough to warrant a new release. Can you guys create one?

@lucab
Copy link
Contributor

lucab commented Mar 13, 2019

@mrguitar 3.1.0 in progress at #175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants