Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SKIP CI] buildah treadmill: also run rootless tests #17798

Merged

Conversation

edsantiago
Copy link
Member

In February we started running rootless bud tests in cron (#17608).
That's nice, but nobody ever looks at cron results. The idea behind
adding a rootless task was to run it in the manual treadmill, too.
This PR enables that, and more clearly documents the how and why.

Signed-off-by: Ed Santiago santiago@redhat.com

None

In February we started running rootless bud tests in cron (containers#17608).
That's nice, but nobody ever looks at cron results. The idea behind
adding a rootless task was to run it in the manual treadmill, too.
This PR enables that, and more clearly documents the how and why.

Signed-off-by: Ed Santiago <santiago@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@edsantiago
Copy link
Member Author

[SKIP CI] because this script is never used anywhere except by me and maybe a buildah-vendoring dev. There's no destabilization risk here,

This is what the new task map looks like:
cirrus-map-vendor_buildah_latest
(i.e., the yellow blocks run first, and all other tests depend on them)


...and this is what an in-progress CI run looks like:
treadmill-step1
(i.e., the rootless jobs are not running, and don't run until rootful ones pass).

@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2023

LGTM

@Luap99
Copy link
Member

Luap99 commented Mar 17, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2023
@openshift-merge-robot openshift-merge-robot merged commit 97f2107 into containers:main Mar 17, 2023
@edsantiago edsantiago deleted the treadmill_add_rootless branch March 20, 2023 12:31
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants