CI: new rootless buildah-bud tests (cron only) #17608
Conversation
openshift-ci
bot
added
release-note-none
approved
|
I will be on PTO once the first results of this come in. If that's too high-risk for the team, I'm fine with this waiting. |
|
LGTM |
|
Correct. Not only are they not blocking, they probably won't even be noticed by anyone. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich, edsantiago The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
They DO pop up when they fail on our podman-monitor e-mails. I'm not opposed to taking action, I'm just ignorant of what that should be. Best I've got is: If it breaks a lot, fwd the notice to the team. Maybe that's good enough? @edsantiago if you have time, would you consider adding an idem to our podman-monitor cheat-sheet for how you'd like failures handled? |
edsantiago
force-pushed
the
rootless_bud_tests_in_cron
branch
from
e224e2f
to
1b654e5
Compare
|
Done: added a bullet item to the cheat sheet. (If treadmill ever fails with a non-flake, everyone needs to know about it) |
Run rootless bud tests as part of the nightly treadmill job. Reason: containers#17480 could have been caught before release. Also: refactored bot this and bud_test_task (the task which I copypasted to form this one) to use *stdenvars; thanks @cevich for catching that. Signed-off-by: Ed Santiago <santiago@redhat.com>
edsantiago
force-pushed
the
rootless_bud_tests_in_cron
branch
from
1b654e5
to
5a08dda
Compare
|
Thanks @edsantiago We'll keep a closer eye on the job while you're out, (cc: @lsm5). /lgtm |
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
Followup to containers#17608, rootless buildah-bud in cron. I forgot one crucial step, skipping the sudo. Signed-off-by: Ed Santiago <santiago@redhat.com>
Another followup to containers#17608. Nightly tests were hanging, because /run/podman/podman.sock was hardcoded (bad idea for rootless). Poor testing on my part. Signed-off-by: Ed Santiago <santiago@redhat.com>
In February we started running rootless bud tests in cron (containers#17608). That's nice, but nobody ever looks at cron results. The idea behind adding a rootless task was to run it in the manual treadmill, too. This PR enables that, and more clearly documents the how and why. Signed-off-by: Ed Santiago <santiago@redhat.com>
github-actions
bot
added
the
locked - please file new issue/PR
Run rootless bud tests as part of the nightly treadmill job.
Reason: #17480 could have been caught before release.
Signed-off-by: Ed Santiago santiago@redhat.com