Quadlet: add support for setting --ip and --ip6

[restitux]

Add support for IP= and IP6=.

Added support for specifying static IPv4 and IPv6 addresses in Quadlet .container files via the IP= and IP6= options.

[rhatdan]

I don't believe any of the logs belong in here?
test/e2e/ginkgo-node-1.log

[vrothberg]

Thanks for contributing!

[ygalblum]

I think you're missing an empty line between the commit's title and the signoff comment.

[Luap99]

I would not recommend using --ip or --ipv6, they do not work when using more than one network.

I haven't actually tested this but quadlet already supports Network= and the cli syntax to properly set static ip/ipv6/mac is this: network:ip=192.168.1.10. This allows you to set a static ip for each network that is specified. The options are described here: https://docs.podman.io/en/latest/markdown/podman-create.1.html#network-mode-net

This was added with podman 4.0, the --ip and --ip6 options mostly exists because of backwards/docker compat.
I will leave it to the quadlet maintainers to decide if they want these options but I say the new syntax is much better because it support all network options.

[TomSweeneyRedHat]

@ygalblum looks like you need to sign this.
Other than the logs that @vrothberg pointed out, LGTM

[restitux]

@Luap99 using the ip parameter on a network via Network= does in fact work with quadlet, that's actually what I'm using in lieu of this PR.

[restitux]

I think you're missing an empty line between the commit's title and the signoff comment.

The signoff should be fixed now, I made a new commit when I deleted the logs. LMK if there are still issues

[ygalblum]

@TomSweeneyRedHat I was waiting for the decision regarding the name.
/lgtm
/hold

[ygalblum]

/hold cancel

[ygalblum]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: restitux, ygalblum

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ygalblum]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhatdan]

@ygalblum Could you respond to @Luap99 about this? Should we have two ways to handle this? Especially when we sort of deprecate the ip and ip6 way?

[ygalblum]

@rhatdan @Luap99 I don't see any harm in supporting in Quadlet whatever Podman already supports. In addition, I do see a benefit in supporting and using simple flags whenever possible. I understand the issue with multiple networks, but, I think that still most cases use a single one.