Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: COPY hardlinks #17979

Closed
edsantiago opened this issue Mar 29, 2023 · 1 comment · Fixed by #18171
Closed

build: COPY hardlinks #17979

edsantiago opened this issue Mar 29, 2023 · 1 comment · Fixed by #18171
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@edsantiago
Copy link
Member

Four in the last few weeks:

not ok 196 podman build COPY hardlinks
...
$ podman build -t build_test /tmp/podman_bats.oooMRE/build-test
 ...
$ podman run --rm build_test stat -c %i /test/Dockerfile
529493
$ podman run --rm build_test stat -c %i /test/hardlink1
529492
#/vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
#|     FAIL: COPY hardlinks work
#| expected: '529493'
#|   actual: '529492'
#\^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

I don't see any equivalent failures in the buildah flake catalog. (Note: this is a podman-only test, not a buildah-bud test run in podman). I don't actually see any equivalent test in buildah, the closest is bud-copy-dockerignore-hardlinks but that tests mount, not running in the container itself.

[sys] podman build COPY hardlinks
@edsantiago edsantiago added flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. labels Mar 29, 2023
@edsantiago
Copy link
Member Author

The problem has not magically gone away:

edsantiago added a commit to edsantiago/libpod that referenced this issue Apr 12, 2023
@edsantiago
system tests: address COPY-hardlink flake
51b582d 
Possible cause: on Debian, maybe because of fuse-overlayfs(??),
we sometimes see unexpected inode numbers.

This PR tightens the test logic, so it runs one 'stat' command
in only one podman invocation, then cross-checks multiple lines
of output. I don't know if this will really fix the flake, but
even if it doesn't, it will at least give us much more useful
diagnostic output than before.

And, as long as I'm in here, clean up test, remove duplication,
make error messages distinct (hence more useful), and comment.

Fixes: containers#17979

Signed-off-by: Ed Santiago <santiago@redhat.com>
@edsantiago edsantiago mentioned this issue Apr 12, 2023
Merged
edsantiago added a commit to Luap99/libpod that referenced this issue Apr 13, 2023
@edsantiago
system tests: address COPY-hardlink flake
6a663d9 
Possible cause: on Debian, maybe because of fuse-overlayfs(??),
we sometimes see unexpected inode numbers.

This PR tightens the test logic, so it runs one 'stat' command
in only one podman invocation, then cross-checks multiple lines
of output. I don't know if this will really fix the flake, but
even if it doesn't, it will at least give us much more useful
diagnostic output than before.

And, as long as I'm in here, clean up test, remove duplication,
make error messages distinct (hence more useful), and comment.

Fixes: containers#17979

Signed-off-by: Ed Santiago <santiago@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Aug 27, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
flakes Flakes from Continuous Integration kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

system tests: address COPY-hardlink flake edsantiago/libpod
1 participant
@edsantiago