Closes: 15858 (podman system reset --force destroy machine) #16268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
|
I rejigged my fork, and accidentally closed the previous WIP PR: #15904. Waiting on CICD, and then will attempt to remove draft. |
Safe guards calls to os.RemoveAll in order to prevent calls from accidently deleting the root file system in very strange edge cases. Did this by creating GuardedRemoveAll and migrated machine os.RemoveAll calls to it. Signed-off-by: Mike Perry <mike@bitbistro.org>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, mikewwwperry The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
vrothberg
reviewed
Oct 24, 2022
| // will not delete certain catastrophic paths. | ||
| func GuardedRemoveAll(path string) error { | ||
| if path == "" || path == "/" { | ||
| return fmt.Errorf("refusing to recusively delete `%s`", path) |
There was a problem hiding this comment.
Suggested change
| return fmt.Errorf("refusing to recusively delete `%s`", path) | |
| return fmt.Errorf("refusing to recusively delete %q", path) |
%q will do the quoting for us.
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
github-actions
bot
added
the
locked - please file new issue/PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe guards calls to os.RemoveAll in order to prevent calls from accidently deleting the root file system in very strange edge cases. Did this by creating GuardedRemoveAll and migrated machine os.RemoveAll calls to it.
Signed-off-by: Mike Perry mike@bitbistro.org
Closes #15858
Does this PR introduce a user-facing change?