Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] podman system reset --force destroy machine #15904

Closed
wants to merge 0 commits into from
Closed

[WIP] podman system reset --force destroy machine #15904

wants to merge 0 commits into from

Conversation

BitBistro
Copy link
Contributor

Created GuardedRemoveAll and migrated machine os.RemoveAll calls to it.

Closes #15858

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 22, 2022

@BitBistro-code: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None label Sep 22, 2022
@rhatdan rhatdan changed the title Draft: podman system reset --force destroy machine [WIP] podman system reset --force destroy machine Sep 22, 2022
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2022
@BitBistro BitBistro mentioned this pull request Sep 22, 2022
Closed
@mheon
Copy link
Member

mheon commented Sep 22, 2022

LGTM

@github-actions github-actions bot added the kind/api-change Change to remote API; merits scrutiny label Oct 20, 2022
@github-actions github-actions bot removed the kind/api-change Change to remote API; merits scrutiny label Oct 20, 2022
@BitBistro
Copy link
Contributor Author

I've updated the commit message with the sign-off. Let me know if you have any questions.

@BitBistro BitBistro closed this Oct 23, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mikewwwperry

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BitBistro BitBistro mentioned this pull request Oct 23, 2022
Merged
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

podman system reset --force destroy machine
2 participants
@BitBistro @mheon