use libnetwork from c/common #12642

Luap99 · 2021-12-17T13:53:12Z

The libpod/network packages were moved to c/common so that buildah can
use it as well. To prevent duplication use it in podman as well and
remove it from here.

Signed-off-by: Paul Holzinger pholzing@redhat.com

openshift-ci · 2021-12-17T13:53:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mheon · 2021-12-17T14:55:08Z

LGTM once the c/common PR merges.

rhatdan · 2022-01-11T15:23:53Z

Containers/common has been merged, could you rebase.

Luap99 · 2022-01-11T15:31:34Z

There is no point, I sill need the buildah PR.

The libpod/network packages were moved to c/common so that buildah can use it as well. To prevent duplication use it in podman as well and remove it from here. Signed-off-by: Paul Holzinger <pholzing@redhat.com>

edsantiago · 2022-01-12T22:00:40Z

Aw, phooey. I just looked at the podman-remote failures, and there are a whole lot more than in local. I'm working on those right now.

- reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip two failing tests that I don't know how to fix: a) --unsetenv is not passed on to buildah (should be easy) b) something manifest-related - skip a bunch more podman-remote tests. Filed an issue for one of them (containers#12838), the others may not be fixable. Signed-off-by: Ed Santiago <santiago@redhat.com>

edsantiago · 2022-01-12T22:32:21Z

Okay, I've force-pushed updates to Luap99#2 which I think cover all the errors.

Please do not just blindly merge that (unless this PR is time-critical). Please, someone buildah-savvy, look at all these new added skips and either (a) fix them or (b) move the skips to a different section of the script, with an explanation of why these won't be fixed.

HTH

TomSweeneyRedHat · 2022-01-12T23:28:28Z

docs/source/markdown/podman-build.1.md

@@ -54,6 +54,10 @@ Add a custom host-to-IP mapping (host:ip)
 Add a line to /etc/hosts. The format is hostname:ip. The **--add-host** option
 can be set multiple times.

+#### **--all-platforms**
+
+Instead of building for a set of platforms specified using the **--platform** option, inspect the build's base images, and build for all of the platforms for which they are all available.  Stages that use *scratch* as a starting point can not be inspected, so at least one non-*scratch* stage must be present for detection to work usefully.


I'm struggling with the first sentence. I think this is better, but I'm not sure it's right or that I like it a lot. Maybe "found" instead of "available" in my suggestion?

Suggested change

Instead of building for a set of platforms specified using the **--platform** option, inspect the build's base images, and build for all of the platforms for which they are all available. Stages that use *scratch* as a starting point can not be inspected, so at least one non-*scratch* stage must be present for detection to work usefully.

Instead of building for a set of platforms specified using the **--platform** option, inspect the build's base images, and build for all of the platforms that are available. Stages that use *scratch* as a starting point can not be inspected, so at least one non-*scratch* stage must be present for detection to work usefully.

I can fix this here but this is copy paste from buildah-bud so someone should fix it there as well.

- reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip two failing tests that I don't know how to fix: a) --unsetenv is not passed on to buildah (should be easy) b) something manifest-related - skip a bunch more podman-remote tests. Filed an issue for one of them (containers#12838), the others may not be fixable. Signed-off-by: Ed Santiago <santiago@redhat.com>

- reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip two failing tests that I don't know how to fix: a) --unsetenv is not passed on to buildah (should be easy) b) something manifest-related - skip a bunch more podman-remote tests. Filed an issue for one of them (containers#12838), the others may not be fixable. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Make sure we add support for allplatforms and unsetenv to both local and remote podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>

- reenable git:// tests - git command fails with (EVIL) status 128. Deal with it. - skip a bunch more podman-remote tests. Filed an issue for one of them (containers#12838), the others may not be fixable. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Luap99 · 2022-01-13T15:26:17Z

OK all tests were green now except one podman-remote build test bud with containerfile env secret priority which I now also added to skip list since it secrets do not work on remote

Luap99 · 2022-01-13T15:26:46Z

@baude @mheon @rhatdan @edsantiago PTAL This should go green now

mheon · 2022-01-13T15:43:16Z

LGTM!

mheon · 2022-01-13T15:43:40Z

/lgtm
/hold

edsantiago · 2022-01-13T16:00:02Z

LGTM

Luap99 · 2022-01-13T17:04:47Z

/hold cancel

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 17, 2021

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2021

Luap99 mentioned this pull request Dec 17, 2021

add libnetwork package containers/common#863

Merged

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 26, 2021

Luap99 mentioned this pull request Jan 3, 2022

[CI:DOCS] fix doc typo #12731

Merged

junnplus mentioned this pull request Jan 3, 2022

fix typo containers/common#871

Merged

Luap99 force-pushed the libnetwork branch from f8a1c2c to 057b04a Compare January 3, 2022 13:26

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 3, 2022

Luap99 force-pushed the libnetwork branch 2 times, most recently from 7c85073 to 26f1bdc Compare January 3, 2022 19:22

Luap99 mentioned this pull request Jan 4, 2022

libnetwork: add function to get the default network backend containers/common#872

Merged

Luap99 force-pushed the libnetwork branch 3 times, most recently from fecbafb to 2103d75 Compare January 6, 2022 20:04

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 7, 2022

Luap99 force-pushed the libnetwork branch from 2103d75 to c4e6eeb Compare January 7, 2022 17:14

openshift-ci bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 7, 2022

This was referenced Jan 12, 2022

api: remove use of deprecated/removed constants for CNI from buildah #12822

Closed

Update vendoring in buildah,common, image #12794

Closed

use libnetwork from c/common

495884b

The libpod/network packages were moved to c/common so that buildah can use it as well. To prevent duplication use it in podman as well and remove it from here. Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Luap99 force-pushed the libnetwork branch from c4e6eeb to 5478288 Compare January 12, 2022 16:09

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2022

Luap99 changed the title ~~[WIP] use libnetwork from c/common~~ use libnetwork from c/common Jan 12, 2022

Luap99 marked this pull request as ready for review January 12, 2022 16:10

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 12, 2022

TomSweeneyRedHat reviewed Jan 12, 2022

View reviewed changes

Luap99 force-pushed the libnetwork branch from 6530644 to 412fdaa Compare January 13, 2022 13:38

Luap99 force-pushed the libnetwork branch from 412fdaa to 1d4523d Compare January 13, 2022 13:50

podman build enable --all-platforms and --unsetenv

92e7875

Make sure we add support for allplatforms and unsetenv to both local and remote podman. Signed-off-by: Paul Holzinger <pholzing@redhat.com>

Luap99 force-pushed the libnetwork branch from 1d4523d to 64893d2 Compare January 13, 2022 14:04

Luap99 force-pushed the libnetwork branch from 64893d2 to ece768f Compare January 13, 2022 15:24

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022

openshift-ci bot assigned mheon Jan 13, 2022

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2022

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2022

openshift-merge-robot merged commit eeb76db into containers:main Jan 13, 2022

Luap99 deleted the libnetwork branch January 13, 2022 17:06

flouthoc mentioned this pull request Jan 14, 2022

volume: add support for non-volatile upperdir,workdir for overlay volumes #12712

Merged

2 tasks

github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023

github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use libnetwork from c/common #12642

use libnetwork from c/common #12642

Luap99 commented Dec 17, 2021

openshift-ci bot commented Dec 17, 2021

mheon commented Dec 17, 2021

rhatdan commented Jan 11, 2022

Luap99 commented Jan 11, 2022

edsantiago commented Jan 12, 2022

edsantiago commented Jan 12, 2022

TomSweeneyRedHat Jan 12, 2022

Luap99 Jan 13, 2022

Luap99 commented Jan 13, 2022

Luap99 commented Jan 13, 2022

mheon commented Jan 13, 2022

mheon commented Jan 13, 2022

edsantiago commented Jan 13, 2022

Luap99 commented Jan 13, 2022

	Instead of building for a set of platforms specified using the --platform option, inspect the build's base images, and build for all of the platforms for which they are all available. Stages that use scratch as a starting point can not be inspected, so at least one non-scratch stage must be present for detection to work usefully.
	Instead of building for a set of platforms specified using the --platform option, inspect the build's base images, and build for all of the platforms that are available. Stages that use scratch as a starting point can not be inspected, so at least one non-scratch stage must be present for detection to work usefully.

use libnetwork from c/common #12642

use libnetwork from c/common #12642

Conversation

Luap99 commented Dec 17, 2021

openshift-ci bot commented Dec 17, 2021

mheon commented Dec 17, 2021

rhatdan commented Jan 11, 2022

Luap99 commented Jan 11, 2022

edsantiago commented Jan 12, 2022

edsantiago commented Jan 12, 2022

TomSweeneyRedHat Jan 12, 2022

Choose a reason for hiding this comment

Luap99 Jan 13, 2022

Choose a reason for hiding this comment

Luap99 commented Jan 13, 2022

Luap99 commented Jan 13, 2022

mheon commented Jan 13, 2022

mheon commented Jan 13, 2022

edsantiago commented Jan 13, 2022

Luap99 commented Jan 13, 2022