libnetwork: add function to get the default network backend #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Luap99
force-pushed
the
default-network-interface
branch
2 times, most recently
from
1df9945
to
2fce8d4
Compare
|
I also added this to containers/podman#12642 but it looks like there is some not networking related regression in c/common which is causing failures in podman. |
mheon
reviewed
Jan 4, 2022
When the network backend is unset in the config we have to to figure out
if we need CNI or netavark. New installs should use netavark while
existing installs should continue to use CNI to prevent breaking
systems.
We use the following conditions to determine what backend to use:
1. read ${graphroot}/defaultNetworkBackend
2. find netavark binary (if not installed use CNI)
3. check containers, images and CNI networks and if there are some
we have an existing install and should continue to use CNI
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
If the caller can decide the lockfile path it is just more likely that there is a lock missmatch due different lock names. We should always just use the config dir and use a lock with a static name. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
We should not use XDG_RUNTIME_DIR for the ipam db. This directory is shared but we need the ipam db per storage. We can use the runroot for this. It should be a tmpfs to reset the ipam assignments after a reboot. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
force-pushed
the
default-network-interface
branch
from
2fce8d4
to
34e2806
Compare
|
LGTM |
The HardwareAddr type must bbe the actual value and not a pointer otherwise the marshal logic will not use this function. Added a test to confirm that this works. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the network backend is unset in the config we have to to figure out
if we need CNI or netavark. New installs should use netavark while
existing installs should continue to use CNI to prevent breaking
systems.
We use the following conditions to determine what backend to use:
we have an existing install and should continue to use CNI