GetCapacityResponse: promote maximum_volume_size #499
Conversation
|
may be its good to give some references in the PR description to its usage in kube or csi drivers as we are promoting this field. |
|
I've added some links. |
|
/lgtm |
|
/assign @saad-ali |
|
lgtm.. |
|
RIP travis.org
Please regenerate the Go bindings since you're changing a protobuf descriptor. |
Kubernetes and several CSI drivers have been using that field for a while now and no changes to the semantic are expected, therefore the alpha status can and should be removed. The minimum_volume_size field is not used by Kubernetes. The semantic is probably stable, but further practical experience with it might be desirable before promoting it.
pohly
force-pushed
the
maximum-volume-size
branch
from
b8056f8
to
3175f6b
Compare
|
It looks like updating lib/go/csi/csi.pb.go was also skipped in d64255d. Some of the changes that I got are from that commit. The reason I missed the lib/go/csi update is that I expected the top-level "make" to update everything. Would it make sense to add that? |
probably, maybe in a follow-up PR? |
|
Can this be merged and included in a new release? |
|
The fix for the Makefile is in #500. I did not include the updated lib/go/csi/csi.pb.go there because that's already pending here, but it might be cleaner to merge that change via the other PR. |
|
CC @saad-ali |
|
/lgtm |
Opened #501 |
Kubernetes and several CSI drivers (for example, PMEM-CSI) have been using that field for a while now
and no changes to the semantic are expected, therefore the alpha status can and
should be removed.
The minimum_volume_size field is not used by Kubernetes. The semantic is
probably stable, but further practical experience with it might be desirable
before promoting it.