Skip to content

Commit

Permalink
GetCapacityResponse: promote maximum_volume_size
Browse files Browse the repository at this point in the history
Kubernetes and several CSI drivers have been using that field for a while now
and no changes to the semantic are expected, therefore the alpha status can and
should be removed.

The minimum_volume_size field is not used by Kubernetes. The semantic is
probably stable, but further practical experience with it might be desirable
before promoting it.
  • Loading branch information
pohly committed Mar 15, 2022
1 parent 5b0d454 commit b8056f8
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -988,8 +988,7 @@ message GetCapacityResponse {
// a maximum size for individual volumes and leave it unset
// otherwise. COs MAY use it to make decision about
// where to create volumes.
google.protobuf.Int64Value maximum_volume_size = 2
[(alpha_field) = true];
google.protobuf.Int64Value maximum_volume_size = 2;

// The smallest size that may be used in a
// CreateVolumeRequest.capacity_range.limit_bytes field
Expand Down
3 changes: 1 addition & 2 deletions spec.md
Original file line number Diff line number Diff line change
Expand Up @@ -1637,8 +1637,7 @@ message GetCapacityResponse {
// a maximum size for individual volumes and leave it unset
// otherwise. COs MAY use it to make decision about
// where to create volumes.
google.protobuf.Int64Value maximum_volume_size = 2
[(alpha_field) = true];
google.protobuf.Int64Value maximum_volume_size = 2;
// The smallest size that may be used in a
// CreateVolumeRequest.capacity_range.limit_bytes field
Expand Down

0 comments on commit b8056f8

Please sign in to comment.