Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Ginkgo and Gomega with Testify #111

Merged
merged 1 commit into from
Jun 24, 2022

Conversation

sergefdrv
Copy link
Contributor

@sergefdrv sergefdrv commented Jun 22, 2022

Some of the reasons to prefer native Go testing with Testify:

  • Ginkgo doesn't seem very convenient to use, e.g. running an
    arbitrary subset of tests
  • Ginkgo doesn't seem to have native integration with Go's benchmark
    or fuzz testing facilities

@sergefdrv sergefdrv force-pushed the ginkgo-replacement branch 3 times, most recently from 92cb632 to 0805890 Compare June 23, 2022 10:21
@sergefdrv sergefdrv marked this pull request as ready for review June 23, 2022 10:21
@sergefdrv sergefdrv self-assigned this Jun 23, 2022
Copy link
Contributor

@matejpavlovic matejpavlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Some of the reasons to prefer native Go testing with Testify:
 - Ginkgo doesn't seem very convenient to use, e.g. running an
   arbitrary subset of tests
 - Ginkgo doesn't seem to have native integration with Go's benchmark
   or fuzz testing facilities

Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants