Skip to content

Commit

Permalink
testing: Replace Ginkgo and Gomega with Testify
Browse files Browse the repository at this point in the history
Some of the reasons to prefer native Go testing with Testify:
 - Ginkgo doesn't seem very convenient to use, e.g. running an
   arbitrary subset of tests
 - Ginkgo doesn't seem to have native integration with Go's benchmark
   or fuzz testing facilities

Signed-off-by: Sergey Fedorov <sergey.fedorov@protocol.ai>
  • Loading branch information
Sergey Fedorov committed Jun 23, 2022
1 parent 5b1f783 commit 0805890
Show file tree
Hide file tree
Showing 9 changed files with 244 additions and 430 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ clean:

.PHONY: test
test:
go test -race
go test -race ./...

.PHONY: lint
lint:
Expand Down
25 changes: 0 additions & 25 deletions cmd/mircat/main_test.go

This file was deleted.

15 changes: 0 additions & 15 deletions cmd/mircat/mircat_suite_test.go

This file was deleted.

16 changes: 4 additions & 12 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ require (
github.com/AlecAivazis/survey/v2 v2.3.2
github.com/alecthomas/template v0.0.0-20190718012654-fb15b899a751 // indirect
github.com/alecthomas/units v0.0.0-20211218093645-b94a6e3cc137 // indirect
github.com/dgraph-io/badger/v2 v2.2007.2
github.com/onsi/ginkgo/v2 v2.1.4
github.com/onsi/gomega v1.19.0
github.com/otiai10/copy v1.7.0
github.com/pkg/errors v0.9.1
github.com/stretchr/testify v1.7.0
github.com/tidwall/gjson v1.14.1 // indirect
github.com/tidwall/wal v1.1.7
github.com/ttacon/chalk v0.0.0-20160626202418-22c06c80ed31
Expand All @@ -22,18 +21,11 @@ require (
gopkg.in/alecthomas/kingpin.v2 v2.2.6
)

require github.com/stretchr/testify v1.7.0

require (
github.com/DataDog/zstd v1.4.1 // indirect
github.com/cespare/xxhash v1.1.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/dgraph-io/ristretto v0.0.3-0.20200630154024-f66de99634de // indirect
github.com/dgryski/go-farm v0.0.0-20190423205320-6a90982ecee2 // indirect
github.com/dustin/go-humanize v1.0.0 // indirect
github.com/golang/protobuf v1.5.2 // indirect
github.com/golang/snappy v0.0.1 // indirect
github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
github.com/kr/pretty v0.1.0 // indirect
github.com/mattn/go-colorable v0.1.2 // indirect
github.com/mattn/go-isatty v0.0.8 // indirect
github.com/mgutz/ansi v0.0.0-20170206155736-9520e82c474b // indirect
Expand All @@ -43,6 +35,6 @@ require (
github.com/tidwall/tinylru v1.1.0 // indirect
golang.org/x/term v0.0.0-20210927222741-03fcf44c2211 // indirect
golang.org/x/text v0.3.7 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
gopkg.in/check.v1 v1.0.0-20190902080502-41f04d3bba15 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
60 changes: 7 additions & 53 deletions go.sum

Large diffs are not rendered by default.

65 changes: 0 additions & 65 deletions mir_suite_test.go

This file was deleted.

Loading

0 comments on commit 0805890

Please sign in to comment.