Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete client and handler stream constructors #193

Merged
merged 3 commits into from
Apr 9, 2022
Merged

Delete client and handler stream constructors #193

merged 3 commits into from
Apr 9, 2022

Commits on Apr 7, 2022

  1. Delete client and handler stream constructors 

    These aren't used in the generated code anymore, so we don't need to
export them. They don't do much work either, so we can just delete the
constructors and use a linter to make sure we always initialize future
fields.
    @akshayjshah
    akshayjshah committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    56bbdd7 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Add to GoDoc

    @akshayjshah
    akshayjshah committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    d44c962 View commit details
    Browse the repository at this point in the history

  2. Use mergeHeaders in handler stream too 

    Similar to previous changes to client_stream.go, use the `mergeHeaders`
helper now that all this code is in the same package.
    @akshayjshah
    akshayjshah committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    47f3f4d View commit details
    Browse the repository at this point in the history