-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete client and handler stream constructors #193
Conversation
These aren't used in the generated code anymore, so we don't need to export them. They don't do much work either, so we can just delete the constructors and use a linter to make sure we always initialize future fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to look over this again tomorrow, will check before EOD
Can we add godoc comments to each of the
|
Sure, can do. |
Similar to previous changes to client_stream.go, use the `mergeHeaders` helper now that all this code is in the same package.
Added docs, squash or rebase this in if it looks good to you. |
These aren't used in the generated code anymore, so we don't need to
export them. They don't do much work either, so we can just delete the
constructors and use a linter to make sure we always initialize future
fields.