Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added avro producer for data gen for the new schema registry integrat… #544

Merged
merged 3 commits into from
Dec 19, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/**
* Copyright 2017 Confluent Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
**/


package io.confluent.ksql.datagen;

import org.apache.avro.Schema;
import org.apache.kafka.common.serialization.Serializer;

import io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient;
import io.confluent.kafka.schemaregistry.client.SchemaRegistryClient;
import io.confluent.ksql.GenericRow;
import io.confluent.ksql.serde.avro.KsqlGenericRowAvroSerializer;
import io.confluent.ksql.util.KsqlConfig;
import io.confluent.ksql.util.KsqlException;

public class AvroProducer extends DataGenProducer {

private final KsqlConfig ksqlConfig;
private final SchemaRegistryClient schemaRegistryClient;

public AvroProducer(KsqlConfig ksqlConfig) {
if (ksqlConfig.getString(KsqlConfig.SCHEMA_REGISTRY_URL_PROPERTY) == null) {
throw new KsqlException("Schema registry url is not set.");
}
this.ksqlConfig = ksqlConfig;
this.schemaRegistryClient = new CachedSchemaRegistryClient(ksqlConfig.getString(KsqlConfig
.SCHEMA_REGISTRY_URL_PROPERTY), 100);
}

@Override
protected Serializer<GenericRow> getSerializer(Schema avroSchema,
org.apache.kafka.connect.data.Schema kafkaSchema,
String topicName) {
return new KsqlGenericRowAvroSerializer(kafkaSchema, schemaRegistryClient, ksqlConfig, false);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@
package io.confluent.ksql.datagen;

import io.confluent.avro.random.generator.Generator;
import io.confluent.ksql.util.KsqlConfig;

import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStream;
import java.util.Arrays;
import java.util.Collections;
import java.util.Objects;
import java.util.Optional;
import java.util.Properties;
Expand Down Expand Up @@ -58,6 +60,10 @@ public static void main(String[] args) {
DataGenProducer dataProducer;

switch (arguments.format) {
case AVRO:
dataProducer = new AvroProducer(
new KsqlConfig(Collections.singletonMap(KsqlConfig.SCHEMA_REGISTRY_URL_PROPERTY, arguments.schemaregistryurl)));
break;
case JSON:
dataProducer = new JsonProducer();
break;
Expand Down Expand Up @@ -110,6 +116,7 @@ public enum Format { AVRO, JSON, DELIMITED }
public final String keyName;
public final int iterations;
public final long maxInterval;
public final String schemaregistryurl;

public Arguments(
boolean help,
Expand All @@ -119,7 +126,8 @@ public Arguments(
String topicName,
String keyName,
int iterations,
long maxInterval
long maxInterval,
String schemaregistryurl
) {
this.help = help;
this.bootstrapServer = bootstrapServer;
Expand All @@ -129,6 +137,7 @@ public Arguments(
this.keyName = keyName;
this.iterations = iterations;
this.maxInterval = maxInterval;
this.schemaregistryurl = schemaregistryurl;
}

public static class ArgumentParseException extends RuntimeException {
Expand All @@ -148,6 +157,7 @@ public static class Builder {
private String keyName;
private int iterations;
private long maxInterval;
private String schemaregistryurl;

public Builder() {
quickstart = null;
Expand All @@ -159,6 +169,7 @@ public Builder() {
keyName = null;
iterations = 1000000;
maxInterval = -1;
schemaregistryurl = "http://localhost:8081";
}

private enum Quickstart {
Expand Down Expand Up @@ -201,7 +212,7 @@ public Format getFormat() {

public Arguments build() {
if (help) {
return new Arguments(true, null, null, null, null, null, 0, -1);
return new Arguments(true, null, null, null, null, null, 0, -1, null);
}

if (quickstart != null) {
Expand All @@ -220,7 +231,7 @@ public Arguments build() {
throw new ArgumentParseException(exception.getMessage());
}
return new Arguments(help, bootstrapServer, schemaFile, format, topicName, keyName,
iterations, maxInterval);
iterations, maxInterval, schemaregistryurl);
}

public Builder parseArgs(String[] args) throws IOException {
Expand Down Expand Up @@ -296,6 +307,9 @@ public Builder parseArg(String arg) throws IOException {
case "maxInterval":
maxInterval = parseIterations(argValue);
break;
case "schemaregistryurl":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be camel case to be consistent with the other arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the name.

schemaregistryurl = argValue;
break;
default:
throw new ArgumentParseException(String.format(
"Unknown argument name in '%s'",
Expand Down