Added avro producer for data gen for the new schema registry integrat… #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodesai
reviewed
Dec 19, 2017
| @@ -296,6 +307,9 @@ public Builder parseArg(String arg) throws IOException { | |||
| case "maxInterval": | |||
| maxInterval = parseIterations(argValue); | |||
| break; | |||
| case "schemaregistryurl": | |||
| schemaregistryurl = schemaregistryurl; | |||
There was a problem hiding this comment.
I think this should be argValue?
There was a problem hiding this comment.
Yes, updated it. Thanks.
apurvam
reviewed
Dec 19, 2017
There was a problem hiding this comment.
It looks like that with this change, we can make the pageviews topic in the quickstart be Avro by setting 'format=avro schemaRegistryURL=http://schema-registry:8081` in the docker-compose.yml file?
That's pretty cool!
| @@ -296,6 +307,9 @@ public Builder parseArg(String arg) throws IOException { | |||
| case "maxInterval": | |||
| maxInterval = parseIterations(argValue); | |||
| break; | |||
| case "schemaregistryurl": | |||
There was a problem hiding this comment.
Should be camel case to be consistent with the other arguments.
There was a problem hiding this comment.
Updated the name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion.
This PR adds a new Avro Producer that will generate sample data based on our latest avro support with schema registry integration. The default sr url is localhost:8081 but can be set as a command line parameter using
schemaregistryurlargument.