Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix regression in app id creation #498

Merged
merged 2 commits into from
Dec 6, 2017
Merged

fix regression in app id creation #498

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25bf45c
fix regression in qpp id creation
dguy Dec 4, 2017
a72bcd7
remove addUniqueTimeSuffix boolean
dguy Dec 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ksql-cli/src/test/java/io/confluent/ksql/CliTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ public class CliTest extends TestRunner {
private static TopicConsumer topicConsumer;

private static OrderDataProvider orderDataProvider;
private static int result_stream_no = 0;

@BeforeClass
public static void setUp() throws Exception {
Expand Down Expand Up @@ -181,7 +182,7 @@ private static void testCreateStreamAsSelect(String selectQuery, Schema resultSc
if (!selectQuery.endsWith(";")) {
selectQuery += ";";
}
String resultKStreamName = "RESULT";
String resultKStreamName = "RESULT_" + result_stream_no++;
final String queryString = "CREATE STREAM " + resultKStreamName + " AS " + selectQuery;

/* Start Stream Query */
Expand Down
5 changes: 4 additions & 1 deletion ksql-engine/src/main/java/io/confluent/ksql/physical/PhysicalPlanBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,10 @@ private QueryMetadata buildPlanForStructuredOutputNode(final SchemaKStream schem
}

final QueryId queryId = sinkDataSource.getPersistentQueryId();
final String applicationId = addTimeSuffix(serviceId + persistanceQueryPrefix + queryId);
String applicationId = serviceId + persistanceQueryPrefix + queryId;
if (addUniqueTimeSuffix) {
applicationId = addTimeSuffix(applicationId);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually addUniqueTimeSuffix will always be false here and will always be true for buildPlanForBareQuery method. Maybe we should remove this boolean all together.


KafkaStreams streams = buildStreams(builder, applicationId, ksqlConfig, overriddenStreamsProperties);

Expand Down