fix regression in app id creation #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apurvam
reviewed
Dec 4, 2017
hjafarpour
reviewed
Dec 4, 2017
| String applicationId = serviceId + persistanceQueryPrefix + queryId; | ||
| if (addUniqueTimeSuffix) { | ||
| applicationId = addTimeSuffix(applicationId); | ||
| } |
There was a problem hiding this comment.
Actually addUniqueTimeSuffix will always be false here and will always be true for buildPlanForBareQuery method. Maybe we should remove this boolean all together.
apurvam
approved these changes
Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app id for persistent queries shouldn't have a time stamp suffix applied otherwise it will result in different app ids across different servers.