reset repartition flag after map #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bluemonk3y this seems to fix the JoinIntTest. I ran it with 100% success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the execution plan in
StructuredDataSourceNodewe do astream#map(..)to add the key to theGenericRow. This causes therepartitionRequiredflag to be set to true even though we haven't changed the key. In this case we don't want a repartition as it is unnecessary and also causes issues with the stream/table join, i.e., we end up with nulls when we shouldn't.As a temporary workaround, we use reflection to reset the
repartitionRequiredflag on theKStreamso that joins and aggregations won't require an additional repartitioning. This can be removed once KIP-159 is in as part of AK 1.1