Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override the repartitionRequiredFlag when extracting keys from messages using map #453

Closed
apurvam opened this issue Nov 9, 2017 · 1 comment
Closed

Don't override the repartitionRequiredFlag when extracting keys from messages using map #453

apurvam opened this issue Nov 9, 2017 · 1 comment
Assignees
@guozhangwang
Labels
task

Comments

@apurvam
Copy link
Contributor

apurvam commented Nov 9, 2017

Kafka Streams always repartitions topics when extracting keys from records with the map operation. This is inefficient, and also causes semantic problems like null join, as described in #450 .

Once KIP-159 lands in AK, the hack in #450 should be removed.
@apurvam apurvam added the task label Nov 9, 2017
@apurvam apurvam changed the title Remove hack to meddling with the repartitionRequiredFlag when extracting keys from messages using map Don't override the repartitionRequiredFlag when extracting keys from messages using map Nov 9, 2017
@apurvam apurvam mentioned this issue Nov 9, 2017
Merged
@guozhangwang guozhangwang mentioned this issue Feb 13, 2018
Merged
@apurvam
Copy link
Contributor Author

apurvam commented Feb 13, 2018

Fixed by #718

@apurvam apurvam closed this as completed Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guozhangwang guozhangwang

Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apurvam @guozhangwang