-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: adding stream-table join #375
Merged
bluemonk3y
merged 5 commits into
confluentinc:4.0.x
from
bluemonk3y:4.0.x-TEST-stream-table-join-test
Oct 17, 2017
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
#bootstrap.servers=localhost:1119092 | ||
bootstrap.servers=localhost:9092 | ||
application.id=ksql_server_quickstart | ||
ksql.command.topic.suffix=commands | ||
|
||
listeners=http://localhost:8080 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
97 changes: 97 additions & 0 deletions
97
ksql-engine/src/test/java/io/confluent/ksql/integration/JoinIntTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
package io.confluent.ksql.integration; | ||
|
||
import io.confluent.ksql.GenericRow; | ||
import io.confluent.ksql.KsqlContext; | ||
import io.confluent.ksql.util.ItemDataProvider; | ||
import io.confluent.ksql.util.OrderDataProvider; | ||
import org.apache.kafka.clients.producer.RecordMetadata; | ||
import org.apache.kafka.common.serialization.StringDeserializer; | ||
import org.apache.kafka.connect.data.Schema; | ||
import org.apache.kafka.streams.StreamsConfig; | ||
import org.apache.kafka.test.IntegrationTest; | ||
import org.junit.After; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.junit.experimental.categories.Category; | ||
|
||
import java.util.Arrays; | ||
import java.util.Collections; | ||
import java.util.Map; | ||
|
||
import static org.hamcrest.CoreMatchers.equalTo; | ||
import static org.hamcrest.MatcherAssert.assertThat; | ||
|
||
@Category({IntegrationTest.class}) | ||
public class JoinIntTest { | ||
|
||
private IntegrationTestHarness testHarness; | ||
private KsqlContext ksqlContext; | ||
|
||
|
||
private String orderStreamTopic = "OrderTopic"; | ||
private OrderDataProvider orderDataProvider; | ||
private Map<String, RecordMetadata> orderRecordMetadataMap; | ||
|
||
private String itemTableTopic = "ItemTopic"; | ||
private ItemDataProvider itemDataProvider; | ||
private Map<String, RecordMetadata> itemRecordMetadataMap; | ||
|
||
@Before | ||
public void before() throws Exception { | ||
testHarness = new IntegrationTestHarness(); | ||
testHarness.start(); | ||
Map<String, Object> ksqlStreamConfigProps = testHarness.ksqlConfig.getKsqlStreamConfigProps(); | ||
// turn caching off to improve join consistency | ||
ksqlStreamConfigProps.put(StreamsConfig.CACHE_MAX_BYTES_BUFFERING_CONFIG, 0); | ||
ksqlContext = new KsqlContext(ksqlStreamConfigProps); | ||
|
||
/** | ||
* Setup test data | ||
*/ | ||
testHarness.createTopic(itemTableTopic); | ||
itemDataProvider = new ItemDataProvider(); | ||
|
||
long now = System.currentTimeMillis(); | ||
itemRecordMetadataMap = testHarness.publishTestData(itemTableTopic, itemDataProvider, now-500); | ||
|
||
|
||
testHarness.createTopic(orderStreamTopic); | ||
orderDataProvider = new OrderDataProvider(); | ||
orderRecordMetadataMap = testHarness.publishTestData(orderStreamTopic, orderDataProvider, now ); | ||
|
||
createStreams(); | ||
} | ||
|
||
@After | ||
public void after() throws Exception { | ||
ksqlContext.close(); | ||
testHarness.stop(); | ||
} | ||
|
||
@Test | ||
public void shouldLeftJoinOrderAndItems() throws Exception { | ||
final String testStreamName = "OrderedWithDescription".toUpperCase(); | ||
|
||
final String queryString = String.format( | ||
"CREATE STREAM %s AS SELECT ORDERID, ITEMID, ORDERUNITS, DESCRIPTION FROM orders LEFT JOIN items " + | ||
" on orders.ITEMID = item.ITEMID WHERE orders.ITEMID = 'ITEM_1' ;", | ||
testStreamName | ||
); | ||
|
||
ksqlContext.sql(queryString); | ||
|
||
Schema resultSchema = ksqlContext.getMetaStore().getSource(testStreamName).getSchema(); | ||
|
||
Map<String, GenericRow> expectedResults = Collections.singletonMap("ITEM_1", new GenericRow(Arrays.asList(null, null, "ORDER_1", "ITEM_1", 10.0, "home cinema"))); | ||
|
||
Map<String, GenericRow> results = testHarness.consumeData(testStreamName, resultSchema, 1, new StringDeserializer()); | ||
|
||
assertThat(results, equalTo(expectedResults)); | ||
} | ||
|
||
private void createStreams() throws Exception { | ||
ksqlContext.sql("CREATE STREAM orders (ORDERTIME bigint, ORDERID varchar, ITEMID varchar, ORDERUNITS double, PRICEARRAY array<double>, KEYVALUEMAP map<varchar, double>) WITH (kafka_topic='" + orderStreamTopic + "', value_format='JSON');"); | ||
ksqlContext.sql("CREATE TABLE items (ID varchar, DESCRIPTION varchar) WITH (kafka_topic='" + itemTableTopic + "', value_format='JSON');"); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
ksql-engine/src/test/java/io/confluent/ksql/util/ItemDataProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
/** | ||
* Copyright 2017 Confluent Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
**/ | ||
|
||
package io.confluent.ksql.util; | ||
|
||
import io.confluent.ksql.GenericRow; | ||
import org.apache.kafka.connect.data.Schema; | ||
import org.apache.kafka.connect.data.SchemaBuilder; | ||
|
||
import java.util.Arrays; | ||
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
public class ItemDataProvider extends TestDataProvider { | ||
|
||
private static final String namePrefix = | ||
"ITEM"; | ||
|
||
private static final String ksqlSchemaString = | ||
"(ID varchar, DESCRIPTION varchar)"; | ||
|
||
private static final String key = "ID"; | ||
|
||
private static final Schema schema = SchemaBuilder.struct() | ||
.field("ID", SchemaBuilder.STRING_SCHEMA) | ||
.field("DESCRIPTION", SchemaBuilder.STRING_SCHEMA).build(); | ||
|
||
private static final Map<String, GenericRow> data = new ItemDataProvider().buildData(); | ||
|
||
public ItemDataProvider() { | ||
super(namePrefix, ksqlSchemaString, key, schema, data); | ||
} | ||
|
||
private Map<String, GenericRow> buildData() { | ||
|
||
Map<String, GenericRow> dataMap = new HashMap<>(); | ||
dataMap.put("ITEM_1", new GenericRow(Arrays.asList("ITEM_1", "home cinema"))); | ||
dataMap.put("ITEM_2", new GenericRow(Arrays.asList("ITEM_2", "clock radio"))); | ||
dataMap.put("ITEM_3", new GenericRow(Arrays.asList("ITEM_3", "road bike"))); | ||
dataMap.put("ITEM_4", new GenericRow(Arrays.asList("ITEM_4", "mountain bike"))); | ||
dataMap.put("ITEM_5", new GenericRow(Arrays.asList("ITEM_5", "snowboard"))); | ||
dataMap.put("ITEM_6", new GenericRow(Arrays.asList("ITEM_6", "iphone 10"))); | ||
dataMap.put("ITEM_7", new GenericRow(Arrays.asList("ITEM_7", "gopro"))); | ||
dataMap.put("ITEM_8", new GenericRow(Arrays.asList("ITEM_8", "cat"))); | ||
|
||
return dataMap; | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these comments still relevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point!