TEST: adding stream-table join #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguy
reviewed
Oct 16, 2017
| @@ -17,8 +17,8 @@ | |||
| package io.confluent.ksql; | |||
|
|
|||
| import io.confluent.ksql.metastore.MetaStore; | |||
| import io.confluent.ksql.util.KafkaTopicClientImpl; | |||
| import io.confluent.ksql.util.KsqlConfig; | |||
| import io.confluent.ksql.util.*; | |||
There was a problem hiding this comment.
you probably need to change your import settings?
| result.put(key, recordMetadataFuture.get(TEST_RECORD_FUTURE_TIMEOUT_MS, TimeUnit.MILLISECONDS)); | ||
| } | ||
| producer.close(); | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| private ProducerRecord<String, GenericRow> buildRecord(String topicName, Long timestamp, Map.Entry<String, GenericRow> recordEntry, String key) { | ||
| ProducerRecord<String, GenericRow> producerRecord; | ||
| if (timestamp == null) { |
There was a problem hiding this comment.
You don't need this. Can just pass in null for the timestamp
| @@ -65,7 +65,7 @@ public void shouldAggregateTumblingWindow() throws Exception { | |||
|
|
|||
| // not really required - but lets mess with ms | |||
| Thread.sleep(100); | |||
| testHarness.publishTestData(topicName, dataProvider); | |||
| testHarness.publishTestData(topicName, dataProvider, null); | |||
There was a problem hiding this comment.
Can you get rid of the sleeps in this class now?
|
@dguy - how does that look? we now control time and the future. |
dguy
reviewed
Oct 16, 2017
| @@ -64,8 +67,7 @@ public void after() throws Exception { | |||
| public void shouldAggregateTumblingWindow() throws Exception { | |||
|
|
|||
| // not really required - but lets mess with ms | |||
There was a problem hiding this comment.
Are these comments still relevant?
dguy
approved these changes
Oct 16, 2017
added 2 commits
October 16, 2017 15:53
|
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#375 - adding missing integration tests