-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
security: bump golang 1.21.10 to fix GO-2024-2824 #1836
Conversation
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm thinking the PR checking failure is expected because the quay.io/confidential-containers/golang-fedora:1.21.10-38 is not available yet. I'm thinking the normal process is to merge it and monitor the merged build and fix the failure (if any) by re-run the failed actions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Yes - our options are either to merge like this with PR failures and monitor the build, or to do a two stage commit where we bump the Dockerfile for fedora-golang in one PR and then update in follow ones. |
16768ab
into
confidential-containers:main
Just to round this off, I waited for the fedora-golang image to build and publish and then re-ran the project image build workflow and it worked: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/8998478743 Thanks! |
Fixes: #1825