Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: bump golang 1.21.10 to fix GO-2024-2824 #1836

Merged
merged 1 commit into from
May 8, 2024

Conversation

huoqifeng
Copy link

Fixes: #1825

@huoqifeng huoqifeng changed the title security: bump golang 1.20.10 to fix GO-2024-2824 security: bump golang 1.21.10 to fix GO-2024-2824 May 8, 2024
Fixes: confidential-containers#1825

Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
Copy link
Member

@liudalibj liudalibj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huoqifeng
Copy link
Author

I'm thinking the PR checking failure is expected because the quay.io/confidential-containers/golang-fedora:1.21.10-38 is not available yet. I'm thinking the normal process is to merge it and monitor the merged build and fix the failure (if any) by re-run the failed actions?

Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@stevenhorsman
Copy link
Member

I'm thinking the PR checking failure is expected because the quay.io/confidential-containers/golang-fedora:1.21.10-38 is not available yet. I'm thinking the normal process is to merge it and monitor the merged build and fix the failure (if any) by re-run the failed actions?

Yes - our options are either to merge like this with PR failures and monitor the build, or to do a two stage commit where we bump the Dockerfile for fedora-golang in one PR and then update in follow ones.
I'm personally fine with either, but it's worth noting that we don't have a great track record of remembering to do the follow update, so have ended up on back level base images.

@huoqifeng huoqifeng merged commit 16768ab into confidential-containers:main May 8, 2024
16 of 18 checks passed
@stevenhorsman
Copy link
Member

Yes - our options are either to merge like this with PR failures and monitor the build

Just to round this off, I waited for the fedora-golang image to build and publish and then re-ran the project image build workflow and it worked: https://github.com/confidential-containers/cloud-api-adaptor/actions/runs/8998478743

Thanks!

@huoqifeng huoqifeng deleted the go-fix branch May 8, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test case for libvirt secret retrieve for attestation based on sample TEE
3 participants