-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libvirt: e2e test for attestation for sample tee #1824
libvirt: e2e test for attestation for sample tee #1824
Conversation
529cde5
to
51d3607
Compare
f3183e0
to
8a45203
Compare
Created a cluster and run e2e test like below:
Note, we got trustee/target/release/kbs-cli
|
I'll use a new PR to enable this test case in libvirt_e2e GHA. |
6aadeca
to
f4e7810
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the commits need squashing and we need some information in the commit messages about the changes.
In the instructions can we use: |
I tried to test this locally and hit an error:
I'm not sure of the cause though at the moment. |
Can we also add a negative test here, such that we confirm that set-ups without using the permissive policy get rejected as expected? |
ba38655
to
ee5f9d4
Compare
Yes, agreed |
I think it's because the parameter |
51798d9
to
435a6c4
Compare
|
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
305b81b
to
9829d26
Compare
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
It is probably user error, but the KeyReleaseFailure test is failing for me:
It also doesn't report |
I run it again with after with new trustee repo cloned, looks good:
I'll check your log later @stevenhorsman |
@stevenhorsman can you help cat your |
I think my settings are the same as yours. The only difference I've made is update the test-e2e target to only run the KBS test:
|
It's identified that the PeerPod VM image from quay.io/confidential-containers/podvm-generic-ubuntu-amd64:e5a6fb8fdb34943caceea738770f79b9db87faa1 works well but the image from quay.io/confidential-containers/podvm-generic-ubuntu-amd64:v0.8.2 failed the test. It's interesting. |
Seems |
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
Updated the readme. I'll add this |
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
I've added the |
When I re-built the podvm image with the cc_kbs the tests passed:
|
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
Fixes: confidential-containers#1825 Signed-off-by: Qi Feng Huo <huoqif@cn.ibm.com>
azure e2e test action https://github.com/confidential-containers/cloud-api-adaptor/blob/main/.github/workflows/azure-e2e-test.yml#L224 put trustee repo in ${cloud-api-adaptor-repo-dir}/src/cloud-api-adaptor/test in stead of ${cloud-api-adaptor-repo-dir}/src/cloud-api-adaptor/test/e2e, make correspond change in readme and TRUSTEE_REPO_PATH. |
Fixes: #1825
This PR is based on the azure approach: #1735
AA_KBC_PARAMS
in libvirt provider