Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue 615 #616

Merged
merged 1 commit into from
Apr 22, 2024
Merged

fix: issue 615 #616

merged 1 commit into from
Apr 22, 2024

Conversation

baszalmstra
Copy link
Collaborator

Fixed #615

@baszalmstra baszalmstra requested review from tdejager and wolfv April 22, 2024 08:13
@wolfv wolfv merged commit 3e3239d into conda:main Apr 22, 2024
14 checks passed
@wolfv
Copy link
Contributor

wolfv commented Apr 22, 2024

I will double check with Ruben because I think it's also about nested file requirements. For example, some package might have a requires-dist that points to a specific absolute path and our validation was potentially failing there.

@baszalmstra baszalmstra mentioned this pull request Apr 22, 2024
Merged
baszalmstra added a commit that referenced this pull request Apr 25, 2024
@baszalmstra
chore: release (#617)
0947a8f 
## 🤖 New release
* `rattler`: 0.22.0 -> 0.23.0 (⚠️ API breaking changes)
* `rattler_conda_types`: 0.21.0 -> 0.22.0 (⚠️ API breaking changes)
* `rattler_shell`: 0.20.0 -> 0.20.1 (✓ API compatible changes)
* `rattler_lock`: 0.22.2 -> 0.22.3 (✓ API compatible changes)
* `rattler_package_streaming`: 0.20.4 -> 0.20.5
* `rattler_repodata_gateway`: 0.19.7 -> 0.19.8
* `rattler_solve`: 0.20.6 -> 0.20.7
* `rattler_virtual_packages`: 0.19.7 -> 0.19.8
* `rattler_index`: 0.19.7 -> 0.19.8

### ⚠️ `rattler` breaking changes

```
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field LinkedFile.prefix_placeholder in /tmp/.tmpgNa2Hh/rattler/crates/rattler/src/install/link.rs:126
```

### ⚠️ `rattler_conda_types` breaking changes

```
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field PathsEntry.file_mode in /tmp/.tmpgNa2Hh/rattler/crates/rattler_conda_types/src/prefix_record.rs:92
  field PathsEntry.prefix_placeholder in /tmp/.tmpgNa2Hh/rattler/crates/rattler_conda_types/src/prefix_record.rs:96
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `rattler`
<blockquote>

##
[0.23.0](rattler-v0.22.0...rattler-v0.23.0)
- 2024-04-25

### Added
- Expose paths_data as PathEntry in py-rattler
([#620](#620))
- add support for extracting prefix placeholder data to PathsEntry
([#614](#614))

### Fixed
- compare `UrlOrPath`
([#618](#618))
</blockquote>

## `rattler_conda_types`
<blockquote>

##
[0.22.0](rattler_conda_types-v0.21.0...rattler_conda_types-v0.22.0)
- 2024-04-25

### Added
- add support for extracting prefix placeholder data to PathsEntry
([#614](#614))
</blockquote>

## `rattler_shell`
<blockquote>

##
[0.20.1](rattler_shell-v0.20.0...rattler_shell-v0.20.1)
- 2024-04-25

### Fixed
- compare `UrlOrPath`
([#618](#618))
</blockquote>

## `rattler_lock`
<blockquote>

##
[0.22.3](rattler_lock-v0.22.2...rattler_lock-v0.22.3)
- 2024-04-25

### Fixed
- compare `UrlOrPath`
([#618](#618))
- parse absolute paths on Windows correctly in lockfiles
([#616](#616))
</blockquote>

## `rattler_package_streaming`
<blockquote>

##
[0.20.5](rattler_package_streaming-v0.20.4...rattler_package_streaming-v0.20.5)
- 2024-04-25

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_repodata_gateway`
<blockquote>

##
[0.19.8](rattler_repodata_gateway-v0.19.7...rattler_repodata_gateway-v0.19.8)
- 2024-04-25

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_solve`
<blockquote>

##
[0.20.7](rattler_solve-v0.20.6...rattler_solve-v0.20.7)
- 2024-04-25

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_virtual_packages`
<blockquote>

##
[0.19.8](rattler_virtual_packages-v0.19.7...rattler_virtual_packages-v0.19.8)
- 2024-04-25

### Other
- updated the following local packages: rattler_conda_types
</blockquote>

## `rattler_index`
<blockquote>

##
[0.19.8](rattler_index-v0.19.7...rattler_index-v0.19.8)
- 2024-04-25

### Other
- updated the following local packages: rattler_conda_types
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Signed-off-by: Bas <4995967+baszalmstra@users.noreply.github.com>
Co-authored-by: Bas <4995967+baszalmstra@users.noreply.github.com>
@baszalmstra baszalmstra mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdejager tdejager Awaiting requested review from tdejager

@wolfv wolfv Awaiting requested review from wolfv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UrlOrPath - store absolute Windows URLs with file:///?
2 participants
@baszalmstra @wolfv