feat: add support for extracting prefix placeholder data to PathsEntry #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamthebot
changed the title
|
@baszalmstra you might have to approve workflow runs for this |
baszalmstra
reviewed
Apr 20, 2024
baszalmstra
reviewed
Apr 20, 2024
|
I think you just need to run |
|
@baszalmstra rebased + ran |
|
Nice! That did the trick. @baszalmstra would love to get this merged so I can go ahead and start working on exposing this on the Python side (as part of addressing #613) |
|
Do you also need a release? Or are you working from git? |
Merged
baszalmstra
added a commit
that referenced
this pull request
Apr 25, 2024
## 🤖 New release * `rattler`: 0.22.0 -> 0.23.0 (⚠️ API breaking changes) * `rattler_conda_types`: 0.21.0 -> 0.22.0 (⚠️ API breaking changes) * `rattler_shell`: 0.20.0 -> 0.20.1 (✓ API compatible changes) * `rattler_lock`: 0.22.2 -> 0.22.3 (✓ API compatible changes) * `rattler_package_streaming`: 0.20.4 -> 0.20.5 * `rattler_repodata_gateway`: 0.19.7 -> 0.19.8 * `rattler_solve`: 0.20.6 -> 0.20.7 * `rattler_virtual_packages`: 0.19.7 -> 0.19.8 * `rattler_index`: 0.19.7 -> 0.19.8 ###⚠️ `rattler` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/constructible_struct_adds_field.ron Failed in: field LinkedFile.prefix_placeholder in /tmp/.tmpgNa2Hh/rattler/crates/rattler/src/install/link.rs:126 ``` ###⚠️ `rattler_conda_types` breaking changes ``` --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.30.0/src/lints/constructible_struct_adds_field.ron Failed in: field PathsEntry.file_mode in /tmp/.tmpgNa2Hh/rattler/crates/rattler_conda_types/src/prefix_record.rs:92 field PathsEntry.prefix_placeholder in /tmp/.tmpgNa2Hh/rattler/crates/rattler_conda_types/src/prefix_record.rs:96 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `rattler` <blockquote> ## [0.23.0](rattler-v0.22.0...rattler-v0.23.0) - 2024-04-25 ### Added - Expose paths_data as PathEntry in py-rattler ([#620](#620)) - add support for extracting prefix placeholder data to PathsEntry ([#614](#614)) ### Fixed - compare `UrlOrPath` ([#618](#618)) </blockquote> ## `rattler_conda_types` <blockquote> ## [0.22.0](rattler_conda_types-v0.21.0...rattler_conda_types-v0.22.0) - 2024-04-25 ### Added - add support for extracting prefix placeholder data to PathsEntry ([#614](#614)) </blockquote> ## `rattler_shell` <blockquote> ## [0.20.1](rattler_shell-v0.20.0...rattler_shell-v0.20.1) - 2024-04-25 ### Fixed - compare `UrlOrPath` ([#618](#618)) </blockquote> ## `rattler_lock` <blockquote> ## [0.22.3](rattler_lock-v0.22.2...rattler_lock-v0.22.3) - 2024-04-25 ### Fixed - compare `UrlOrPath` ([#618](#618)) - parse absolute paths on Windows correctly in lockfiles ([#616](#616)) </blockquote> ## `rattler_package_streaming` <blockquote> ## [0.20.5](rattler_package_streaming-v0.20.4...rattler_package_streaming-v0.20.5) - 2024-04-25 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_repodata_gateway` <blockquote> ## [0.19.8](rattler_repodata_gateway-v0.19.7...rattler_repodata_gateway-v0.19.8) - 2024-04-25 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_solve` <blockquote> ## [0.20.7](rattler_solve-v0.20.6...rattler_solve-v0.20.7) - 2024-04-25 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_virtual_packages` <blockquote> ## [0.19.8](rattler_virtual_packages-v0.19.7...rattler_virtual_packages-v0.19.8) - 2024-04-25 ### Other - updated the following local packages: rattler_conda_types </blockquote> ## `rattler_index` <blockquote> ## [0.19.8](rattler_index-v0.19.7...rattler_index-v0.19.8) - 2024-04-25 ### Other - updated the following local packages: rattler_conda_types </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: Bas <4995967+baszalmstra@users.noreply.github.com> Co-authored-by: Bas <4995967+baszalmstra@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a prerequisite for #613. Currently, records in conda-meta contain prefix placeholder metadata. This isn't currently being extracted in
PathsEntry.This PR extracts the placeholder information so
PathsEntrynow contains exactly what's in the records in conda-meta.