-
-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add QD (C++/Fortran quad-double) #2408
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6654838
add QD (C++/Fortran quad-double library)
grlee77 9c66a32
remove libtool from requirements
grlee77 4790196
add toolchain
grlee77 fe73a4a
fix linting error [skip Appveyor]
grlee77 c0948fe
build shared libs as well and update tests
grlee77 2cbfea1
Remove merged recipes
isuruf e197433
Use gfortran from yum
isuruf 1acd3e0
Reset build number
isuruf 72bbc33
Add rpath in Linux as well
isuruf 39505f0
Add isuruf to maintainers
isuruf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
#!/bin/bash | ||
|
||
if [[ `uname` == 'Darwin' ]]; then | ||
# make check below fails on osx unless $PREFIX/lib is added to rpath | ||
LDFLAGS="$LDFLAGS -Wl,-rpath,${PREFIX}/lib" ./configure | ||
else | ||
./configure | ||
fi | ||
|
||
make | ||
make check | ||
make install prefix=${PREFIX} exec_prefix=${PREFIX} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
{% set version = "2.3.17" %} | ||
|
||
package: | ||
name: qd | ||
version: {{ version }} | ||
|
||
source: | ||
fn: qd-{{ version }}.tar.gz | ||
url: http://crd.lbl.gov/~dhbailey/mpdist/qd-{{ version }}.tar.gz | ||
sha256: c58e276f6fcf5f2f442c525f3de42ea00004734572b29c74028bbda0ad81096d | ||
|
||
build: | ||
skip: true # [win] | ||
number: 0 | ||
|
||
requirements: | ||
build: | ||
- toolchain | ||
- gcc | ||
run: | ||
- libgcc | ||
|
||
test: | ||
# make check in build.sh runs tests, these check the installation path | ||
commands: | ||
- test -d ${PREFIX}/include/qd | ||
- test -f ${PREFIX}/lib/libqd.a | ||
- test -f ${PREFIX}/lib/libqdmod.a | ||
- test -f ${PREFIX}/lib/libqd_f_main.a | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are there |
||
- test -f ${PREFIX}/bin/qd-config | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason not to run this program? |
||
|
||
about: | ||
home: http://crd-legacy.lbl.gov/~dhbailey/mpdist/ | ||
license: LBNL-BSD | ||
license_file: COPYING | ||
summary: A C++/Fortran-90 double-double and quad-double package | ||
|
||
extra: | ||
recipe-maintainers: | ||
- grlee77 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you only need
libgfortran
right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is apparently also linking to libquadmath which I believe is included with libgcc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Didn't know that. @conda-forge/core can somebody review this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah for
libquadmath
one needslibgcc
. Also we need to usegcc
on all platforms then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does that work?
gcc
is 4.8.3 andlibgcc
is 5.2.0 in the defaults channel.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4.8.5 I think, but yes they are different.
IIUC
libgcc
5 is backwards compatible withlibgcc
4. The biggest changes forgcc
were for C++11 support, but they provided both the old and new symbols in the newlibgcc
.So not something we should need to worry about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ref: https://gcc.gnu.org/onlinedocs/libstdc++/manual/using_dual_abi.html