add QD (C++/Fortran quad-double) #2408
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/qd:
|
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
recipes/qd/meta.yaml
Outdated
| - toolchain | ||
| - gcc | ||
| run: | ||
| - libgcc |
There was a problem hiding this comment.
you only need libgfortran right?
There was a problem hiding this comment.
It is apparently also linking to libquadmath which I believe is included with libgcc?
There was a problem hiding this comment.
Ah. Didn't know that. @conda-forge/core can somebody review this?
There was a problem hiding this comment.
Yeah for libquadmath one needs libgcc. Also we need to use gcc on all platforms then.
There was a problem hiding this comment.
How does that work? gcc is 4.8.3 and libgcc is 5.2.0 in the defaults channel.
There was a problem hiding this comment.
4.8.5 I think, but yes they are different.
IIUC libgcc 5 is backwards compatible with libgcc 4. The biggest changes for gcc were for C++11 support, but they provided both the old and new symbols in the new libgcc.
So not something we should need to worry about.
There was a problem hiding this comment.
|
Closing and reopening to trigger travis-ci |
recipes/qd/meta.yaml
Outdated
| - test -f ${PREFIX}/lib/libqd.a | ||
| - test -f ${PREFIX}/lib/libqdmod.a | ||
| - test -f ${PREFIX}/lib/libqd_f_main.a | ||
| - test -f ${PREFIX}/bin/qd-config |
There was a problem hiding this comment.
Any reason not to run this program?
| - test -d ${PREFIX}/include/qd | ||
| - test -f ${PREFIX}/lib/libqd.a | ||
| - test -f ${PREFIX}/lib/libqdmod.a | ||
| - test -f ${PREFIX}/lib/libqd_f_main.a |
There was a problem hiding this comment.
Are there sos and dylibs that we can check for?
recipes/qd/meta.yaml
Outdated
|
|
||
| build: | ||
| skip: true # [win] | ||
| number: 3 |
recipes/qd/build.sh
Outdated
| if [[ `uname` == 'Darwin' ]]; then | ||
| # make check below fails on osx unless $PREFIX/lib is added to rpath | ||
| LDFLAGS="$LDFLAGS -Wl,-rpath,${PREFIX}/lib" ./configure | ||
| LDFLAGS="$LDFLAGS -Wl,-rpath,${PREFIX}/lib" ./configure ${config_args} |
There was a problem hiding this comment.
I think this is needed for Linux as well.
|
@grlee77, I've pushed some changes. Hope you don't mind. |
|
LGTM. Thanks @isuruf! |
a C++/Fortran-90 double-double and quad-double package
This is an optional dependency of Elemental (not yet packaged on conda-forge)