Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #279

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Fix dependencies #279

merged 2 commits into from
Sep 21, 2023

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Sep 20, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf isuruf marked this pull request as ready for review September 20, 2023 21:13
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member Author

isuruf commented Sep 21, 2023

Going to merge this and if something breaks we can remove the builds.

@isuruf isuruf merged commit d6a3ae7 into conda-forge:main Sep 21, 2023
6 checks passed
@mbargull
Copy link
Member

mbargull commented Nov 2, 2023

Thanks for looking into that!

It'd be helpful if you add a short description with references for pull requests.
Doesn't have to be much (I actually prefer it to be succinct -- to not waste your and others' time), e.g.,

Fixes <problem> encountered at <issue link> .
refs:
- <additional link 1>
- <additional link 2>

Adding references tremendously helps with (re-)discoverability and traceability (esp. once time passes).

@mfansler
Copy link
Member

To what extent should the changes here be applied to the other branches?

Currently, appears that removing these pinned dependencies from the main branch has led to a situation where the other branches no longer get migrations for their distinct dependencies. A specific example is the libxml2212 migration. A proj931 migration PR on r-rgdal-feedstock cannot solve a valid host environment for any R 4.2 builds due to the latest libgdal using libxml2=2.12, but no r-base=4.2 builds have built against that. That is, main here no longer has libxml2, while the other branches still include it, but there have been no PRs from libxml2212 migration for them.

@jdblischak
Copy link
Member

The lack of libxml2 migration to the 4.2.x branch is also causing a problem in conda-forge/r-tiledb-feedstock#70 (comment). Can we manually open a PR to migrate to libxml2 2.12?

@jdblischak jdblischak mentioned this pull request Dec 22, 2023
4 tasks
@jdblischak
Copy link
Member

For the short-term, I manually opened a PR to migrate r-base 4.2 to libxml2 2.12 (#288). But longer-term it would be nice to somehow address the lack of automated migrations to these supported branches

@mbargull
Copy link
Member

longer-term it would be nice to somehow address the lack of automated migrations to these supported branches

Yep, I've opened regro/cf-scripts#1979 to track this.
But I'm not one of our infrastructure gurus, so can't really tell how much has to be done to get this working...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants