Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include unversioned libopenblas64_.so for Julia #128

Closed
wants to merge 3 commits into from

Conversation

mkitti
Copy link
Contributor

@mkitti mkitti commented Jul 27, 2021

This change will include libopenblas.so and libopenblasw64_.so in the tarball.

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • [-] Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This change is meant to assist in updating the Julia feedstock recipe to a recent version of Julia and to also enable compatibility with Julia's binarybuilder.org packages.

Julia's build process as well additional binary packages from Julia reference an unversioned libopenblas64_.so on 64-bit platforms:

https://github.com/JuliaLang/julia/blob/e6e79f7ab4549ab4d6ffbad22038ebfce1368f93/stdlib/OpenBLAS_jll/src/OpenBLAS_jll.jl#L26-L32

Including a symlink that does not have the version suffix .0 would greatly aid in bringing recent versions of Julia to conda-forge.

This change will include libopenblas.so and libopenblasw64_.so in the tarball.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@mkitti
Copy link
Contributor Author

mkitti commented Jul 27, 2021

Cross referencing conda-forge/julia-feedstock#115

@mkitti mkitti changed the title Include unversioned libopenblas.so for Julia Include unversioned libopenblas64_.so for Julia Jul 27, 2021
@mkitti
Copy link
Contributor Author

mkitti commented Jul 27, 2021

@conda-forge-admin, please rerender

@isuruf
Copy link
Member

isuruf commented Jul 27, 2021

They are included in openblas package instead of libopenblas package.

@mkitti
Copy link
Contributor Author

mkitti commented Jul 27, 2021

They are included in openblas package instead of libopenblas package.

I suppose we can close this then and have julia-feedstock depend on openblas rather than libopenblas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants