Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

another go at fixing 1.6 builds #115

Merged
merged 40 commits into from
Aug 10, 2021
Merged

Conversation

simeonschaub
Copy link
Contributor

@simeonschaub simeonschaub commented Jul 19, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

This is based on #111 and likely to still fail, but I could not find the logs for that PR anymore. Also, would it be possible to run the entire testsuite (should take ~1h with multiple threads), since that is also likely to catch any issues with third-party dependencies?

jmuchovej and others added 8 commits June 9, 2021 21:04
Julia uses this in `deps/Versions.make`
Also removes some likely to be outdated dependencies. This is based on
 conda-forge#111 and likely to still fail, but I could not find the logs for that
PR anymore. Also, would it be possible to run the entire testsuite
(should take ~1h with multiple threads), since that is also likely to
catch any issues with third-party dependencies?
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@simeonschaub
Copy link
Contributor Author

Does anyone know why conda sets NO_GIT=1? Could this just be a relic from previous Julia builds?

@mkitti
Copy link
Contributor

mkitti commented Jul 25, 2021

Does anyone know why conda sets NO_GIT=1? Could this just be a relic from previous Julia builds?

It seems they prefer tarballs:
https://conda-forge.org/docs/maintainer/adding_pkgs.html#tarballs-no-repos

@mkitti
Copy link
Contributor

mkitti commented Jul 25, 2021

Julia cannot find libopenblas:
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=353429&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=410

System library symlink failure: Unable to locate libopenblas.so on your system!
make[2]: *** [/home/conda/feedstock_root/build_artifacts/julia_1626709571149/work/usr/lib/julia/libopenblas.so] Error 1

The openblas-feedstock contains the following shared libraries:

$ $ tar -tvjf libopenblas-0.3.17-pthreads_h8fe5266_0.tar.bz2 | grep libopenblas
-rwxrwxr-x 1001/1001  34643736 2021-07-15 11:08 lib/libopenblasp-r0.3.17.so
lrwxrwxrwx 1001/1001         0 2021-07-15 11:08 lib/libopenblas.so.0 -> libopenblasp-r0.3.17.so

Per
https://github.com/conda-forge/openblas-feedstock/blob/master/recipe/meta.yaml#L57
it specifically does not contain "libopenblas.so"

When using OpenBLAS_jll, Julia normally looks for a file named libopenblas64_.so:
https://github.com/JuliaLang/julia/blob/e6e79f7ab4549ab4d6ffbad22038ebfce1368f93/Make.inc#L1346-L1355

However, since USE_SYSTEM_BLAS=1 and LIBBLASNAME=libopenblas, https://github.com/JuliaLang/julia/blob/835f65d9b9f54e0a8dd856fc940a188f87a48cda/base/Makefile#L208
Julia may be looking for the unversioned "libopenblas.so"

We may need to add a 0 so that Julia looks for "libopenblas.so.0"

$(eval $(call symlink_system_library,BLAS,$(LIBBLASNAME),0))

@mkitti
Copy link
Contributor

mkitti commented Jul 26, 2021

Also a bird told me that Julia's other JLLs depend on "libopenblas64_.so"

https://github.com/JuliaLang/julia/blob/e6e79f7ab4549ab4d6ffbad22038ebfce1368f93/stdlib/OpenBLAS_jll/src/OpenBLAS_jll.jl#L26-L32

See JuliaLang/julia#8734

It sounds like we may need a variant or at least a modification of libopenblas-feedstock similar to https://github.com/JuliaPackaging/Yggdrasil/blob/master/O/OpenBLAS/common.jl#L60-L62

@mkitti
Copy link
Contributor

mkitti commented Jul 26, 2021

Looks like we have a better shot at using libopenblas-ilp64 which has the "64_" suffix. It is also versioned, however:

$ tar -tvjf libopenblas-ilp64-0.3.12-pthreads_hfb7842e_1.tar.bz2 | grep libopenblas
-rwxrwxr-x 1001/1001  32318808 2020-10-24 13:58 lib/libopenblas64_p-r0.3.12.so
lrwxrwxrwx 1001/1001         0 2020-10-24 13:58 lib/libopenblas64_.so.0 -> libopenblas64_p-r0.3.12.so

Why don't they have libopenblas64_.so?

@mkitti
Copy link
Contributor

mkitti commented Jul 27, 2021

For libopenblas64_.so, we should depend on openblas rather than libopenblas per conda-forge/openblas-feedstock#128 (comment)

mkitti and others added 5 commits July 27, 2021 02:10
Julia needs libopenblas64_.so but this is provided by openblas rather than libopenblas.
Use openblas rather than libopenblas
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [35, 44]

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@isuruf
Copy link
Member

isuruf commented Aug 5, 2021

@conda-forge-admin, rerender

recipe/build.sh Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
recipe/meta.yaml Outdated Show resolved Hide resolved
All suggestions were applied

Co-authored-by: Isuru Fernando <isuruf@gmail.com>
USE_SYSTEM_CURL=1 \
USE_SYSTEM_FFTW=1 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does fftw need to be added to the dependencies?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, FFTW isn't a dependency of Julia itself since JuliaLang/julia#21956

@mkitti
Copy link
Contributor

mkitti commented Aug 5, 2021

I ran Base.runtests() from a tarball produced by build-locally.py and got the following results:

Test Summary:                       |     Pass  Fail  Error  Broken     Total
  Overall                           | 38760409    10      3  352602  39113024
    LinearAlgebra/qr                |     4531                           4531
    LinearAlgebra/schur             |      430                            430
    LinearAlgebra/dense             |     7881                           7881
    LinearAlgebra/eigen             |      422                            422
    LinearAlgebra/bunchkaufman      |     5285                           5285
    LinearAlgebra/special           |     3159                           3159
    LinearAlgebra/matmul            |     1028                           1028
    LinearAlgebra/lapack            |      800                            800
    LinearAlgebra/svd               |      525                            525
    LinearAlgebra/tridiag           |     1411                           1411
    LinearAlgebra/cholesky          |     2406                           2406
    LinearAlgebra/bidiag            |     3597                           3597
    LinearAlgebra/diagonal          |     2620                           2620
    LinearAlgebra/lu                |     1287                           1287
    LinearAlgebra/generic           |      530                            530
    LinearAlgebra/uniformscaling    |      510                            510
    LinearAlgebra/lq                |     3005                           3005
    LinearAlgebra/blas              |      687                            687
    LinearAlgebra/hessenberg        |      403                            403
    LinearAlgebra/adjtrans          |      313                            313
    LinearAlgebra/givens            |     1847                           1847
    LinearAlgebra/pinv              |      288                            288
    LinearAlgebra/triangular        |    37696                          37696
    LinearAlgebra/ldlt              |        8                              8
    LinearAlgebra/symmetric         |     2744                           2744
    ambiguous                       |      101                    2       103
    compiler/validation             |       26                             26
    compiler/ssair                  |       38                             38
    compiler/irpasses               |       22                             22
    compiler/codegen                |      138                            138
    compiler/inline                 |       41                    1        42
    compiler/contextual             |        6                              6
    compiler/inference              |      882                    1       883
    strings/basic                   |    87674                          87674
    strings/search                  |      690                            690
    strings/util                    |      460                            460
    strings/io                      |    12751                          12751
    LinearAlgebra/structuredbroadcast |      646                            646
    unicode/utf8                    |       19                             19
    strings/types                   |  2302691                        2302691
    worlds                          |       83                             83
    keywordargs                     |      143                            143
    numbers                         |  1578564                    1   1578565
    core                            |  8445873                    4   8445877
    char                            |     1529                           1529
    triplequote                     |       29                             29
    intrinsics                      |       90                             90
    subtype                         |   337653                   16    337669
    dict                            |   144409                         144409
    hashing                         |    12356                          12356
    iobuffer                        |      204                            204
    staged                          |       64                             64
    offsetarray                     |      465                    3       468
    tuple                           |      578                            578
    subarray                        |   318299                         318299
    reduce                          |     8545                           8545
    arrayops                        |     1978                    2      1980
    reducedim                       |      817                            817
    simdloop                        |      249                            249
    vecelement                      |      678                            678
    rational                        |    98611                    1     98612
    abstractarray                   |    54800                24795     79595
    copy                            |      532                            532
    intfuncs                        |   215854                         215854
    fastmath                        |      934                            934
    functional                      |       95                             95
    math                            |  1520143                        1520143
    operators                       |    12949                          12949
    ordering                        |       35                             35
    path                            |      357                   12       369
    iterators                       |    10067                          10067
    parse                           |    16094                          16094
    loading                         |   132834                         132834
    gmp                             |     2308                           2308
    sorting                         |    12709                   10     12719
    ccall                           |     5331                           5331
    backtrace                       |       35                    1        36
    exceptions                      |       70                             70
    spawn                           |      206                    4       210
    file                            |     1036                           1036
    version                         |     2452                           2452
    namedtuple                      |      194                    1       195
    read                            |     3143                           3143
    mpfr                            |     1135                           1135
    complex                         |     8429                    5      8434
    floatapprox                     |       49                             49
    reflection                      |      403                            403
    regex                           |      114                            114
    float16                         |      131                            131
    combinatorics                   |      170                            170
    sysinfo                         |        4                              4
    env                             |       70                             70
    rounding                        |   112720                         112720
    broadcast                       |      478                    5       483
    mod2pi                          |       80                             80
    euler                           |       12                             12
    ranges                          | 12109750               327693  12437443
    client                          |        3                              3
    errorshow                       |      218                            218
    show                            |     1519                    8      1527
    goto                            |       19                             19
    llvmcall                        |       19                             19
    llvmcall2                       |        7                              7
    ryu                             |    31206                          31206
    some                            |       65                             65
    meta                            |       64                             64
    stacktraces                     |       48                             48
    docs                            |      226                            226
    sets                            |     3518                    1      3519
    binaryplatforms                 |      341                            341
    atexit                          |       40                             40
    LinearAlgebra/addmul            |     8316                           8316
    enums                           |       95                             95
    misc                            |  1282156                        1282156
    interpreter                     |        3                              3
    int                             |   524668                         524668
    bitset                          |      195                            195
    checked                         |     1239                           1239
    boundscheck                     |                                No tests
    error                           |       31                             31
    cartesian                       |      233                    3       236
    osutils                         |       42                             42
    channels                        |      237                            237
    iostream                        |       50                             50
    secretbuffer                    |       27                             27
    specificity                     |      175                            175
    bitarray                        |   910626                         910626
    syntax                          |     1399                    1      1400
    reinterpretarray                |      226                            226
    corelogging                     |      231                            231
    missing                         |      472                    1       473
    smallarrayshrink                |       36                             36
    asyncmap                        |      292                            292
    floatfuncs                      |      193                            193
    cmdlineargs                     |      244                    3       247
    SparseArrays/higherorderfns     |     7120                    1      7121
    LibGit2/libgit2                 |      755     2                      757
    Dates/accessors                 |  7723858                        7723858
    Dates/query                     |     1004                           1004
    Dates/adjusters                 |     3149                           3149
    Dates/periods                   |      945                            945
    Dates/rounding                  |      315                            315
    Dates/types                     |      232                            232
    Dates/ranges                    |   350637                         350637
    Dates/io                        |      325                            325
    Dates/conversions               |      160                            160
    Dates/arithmetic                |      377                            377
    ArgTools                        |      180                            180
    Base64                          |     2022                           2022
    Artifacts                       |     1449                           1449
    CompilerSupportLibraries_jll    |        4                              4
    CRC32c                          |      664                            664
    DelimitedFiles                  |       89                             89
    FileWatching                    |      556                            556
    Future                          |                                No tests
    GMP_jll                         |              1                        1
    Downloads                       |      208                            208
    LazyArtifacts                   |        4                              4
    LibCURL                         |        5     1                        6
    LibCURL_jll                     |        1                              1
    LibGit2_jll                     |                     1                 1
    InteractiveUtils                |      249                            249
    LibOSXUnwind_jll                |                                No tests
    LibSSH2_jll                     |                     1                 1
    LibUV_jll                       |        1                              1
    LibUnwind_jll                   |        1                              1
    Libdl                           |       88                    1        89
    MPFR_jll                        |              1                        1
    Logging                         |       39                             39
    Markdown                        |      252                            252
    MbedTLS_jll                     |                     1                 1
    MozillaCACerts_jll              |              1                        1
    Mmap                            |      139                            139
    NetworkOptions                  |     3517     1                     3518
    OpenBLAS_jll                    |        1                              1
    OpenLibm_jll                    |        1                              1
    PCRE2_jll                       |        1     1                        2
    Profile                         |       24                             24
    SparseArrays/sparsevector       |    10298                          10298
    Printf                          |      979                            979
    REPL                            |     1240                    3      1243
    Serialization                   |      119                    1       120
    Random                          |   203266                         203266
    SparseArrays/sparse             |     3823                           3823
    SHA                             |        1                              1
    SuiteSparse_jll                 |              1                        1
    Sockets                         |      165                            165
    TOML                            |      409                    8       417
    Statistics                      |      752                            752
    UUIDs                           |     1029                           1029
    Unicode                         |      758                            758
    Zlib_jll                        |        1                              1
    dSFMT_jll                       |        1                              1
    libLLVM_jll                     |        1                              1
    nghttp2_jll                     |              1                        1
    p7zip_jll                       |        1                              1
    Tar                             |     2597                           2597
    Test                            |      336                   14       350
    SuiteSparse                     |      878                            878
    precompile                      |      115                            115
    SharedArrays                    |      118                            118
    threads                         |        3                              3
    Distributed                     |       12                             12
    stress                          |      118                            118
    FAILURE

The global RNG seed was 0x8371bc650726c5661040844e8bacbae9.

Error in testset LibGit2/libgit2:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/LibGit2/test/libgit2.jl:3171
  Expression: err.code == LibGit2.Error.ECERTIFICATE
   Evaluated: LibGit2.Error.ERROR == LibGit2.Error.ECERTIFICATE
Error in testset LibGit2/libgit2:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/LibGit2/test/libgit2.jl:3172
  Expression: startswith(lowercase(err.msg), lowercase("The SSL certificate is invalid"))
   Evaluated: startswith("user rejected certificate for localhost", "the ssl certificate is invalid")
Error in testset GMP_jll:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/GMP_jll/test/runtests.jl:7
  Expression: vn == v"6.2.0"
   Evaluated: v"6.2.1" == v"6.2.0"
Error in testset LibCURL:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/LibCURL/test/ssl.jl:32
  Expression: res == CURLE_OK
   Evaluated: 0x0000004d == 0x00000000
Error in testset LibGit2_jll:
Error During Test at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:21
  Got exception outside of a @test
  LoadError: Failed to precompile LibGit2_jll [e37daf67-58a4-590a-8e99-b0245dd2ffc5] to /home/mkitti/.julia/compiled/v1.6/LibGit2_jll/jl_HYkTuK.
  Stacktrace:
    [1] error(s::String)
      @ Base ./error.jl:33
    [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::Base.PipeEndpoint, internal_stdout::Base.PipeEndpoint)
      @ Base ./loading.jl:1360
    [3] compilecache(pkg::Base.PkgId, path::String)
      @ Base ./loading.jl:1306
    [4] _require(pkg::Base.PkgId)
      @ Base ./loading.jl:1021
    [5] require(uuidkey::Base.PkgId)
      @ Base ./loading.jl:914
    [6] require(into::Module, mod::Symbol)
      @ Base ./loading.jl:901
    [7] include
      @ ./Base.jl:386 [inlined]
    [8] macro expansion
      @ ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:24 [inlined]
    [9] macro expansion
      @ /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
   [10] macro expansion
      @ ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:23 [inlined]
   [11] macro expansion
      @ ./timing.jl:368 [inlined]
   [12] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
      @ Main ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:21
   [13] (::Distributed.var"#106#108"{Distributed.CallMsg{:call_fetch}})()
      @ Distributed /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278
   [14] run_work_thunk(thunk::Distributed.var"#106#108"{Distributed.CallMsg{:call_fetch}}, print_error::Bool)
      @ Distributed /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:63
   [15] macro expansion
      @ /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278 [inlined]
   [16] (::Distributed.var"#105#107"{Distributed.CallMsg{:call_fetch}, Distributed.MsgHeader, Sockets.TCPSocket})()
      @ Distributed ./task.jl:411
  in expression starting at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/LibGit2_jll/test/runtests.jl:3
Error in testset LibSSH2_jll:
Error During Test at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:21
  Got exception outside of a @test
  LoadError: Failed to precompile LibSSH2_jll [29816b5a-b9ab-546f-933c-edad1886dfa8] to /home/mkitti/.julia/compiled/v1.6/LibSSH2_jll/jl_wUSPV2.
  Stacktrace:
    [1] error(s::String)
      @ Base ./error.jl:33
    [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::Base.PipeEndpoint, internal_stdout::Base.PipeEndpoint)
      @ Base ./loading.jl:1360
    [3] compilecache(pkg::Base.PkgId, path::String)
      @ Base ./loading.jl:1306
    [4] _require(pkg::Base.PkgId)
      @ Base ./loading.jl:1021
    [5] require(uuidkey::Base.PkgId)
      @ Base ./loading.jl:914
    [6] require(into::Module, mod::Symbol)
      @ Base ./loading.jl:901
    [7] include
      @ ./Base.jl:386 [inlined]
    [8] macro expansion
      @ ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:24 [inlined]
    [9] macro expansion
      @ /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
   [10] macro expansion
      @ ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:23 [inlined]
   [11] macro expansion
      @ ./timing.jl:368 [inlined]
   [12] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
      @ Main ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:21
   [13] (::Distributed.var"#106#108"{Distributed.CallMsg{:call_fetch}})()
      @ Distributed /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278
   [14] run_work_thunk(thunk::Distributed.var"#106#108"{Distributed.CallMsg{:call_fetch}}, print_error::Bool)
      @ Distributed /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:63
   [15] macro expansion
      @ /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278 [inlined]
   [16] (::Distributed.var"#105#107"{Distributed.CallMsg{:call_fetch}, Distributed.MsgHeader, Sockets.TCPSocket})()
      @ Distributed ./task.jl:411
  in expression starting at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/LibSSH2_jll/test/runtests.jl:3
Error in testset MPFR_jll:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/MPFR_jll/test/runtests.jl:7
  Expression: vn == v"4.1.0"
   Evaluated: v"4.0.2" == v"4.1.0"
Error in testset MbedTLS_jll:
Error During Test at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:21
  Got exception outside of a @test
  LoadError: InitError: could not load library "libmbedcrypto.so.5"
  libmbedcrypto.so.5: cannot open shared object file: No such file or directory
  Stacktrace:
    [1] dlopen(s::String, flags::UInt32; throw_error::Bool)
      @ Base.Libc.Libdl ./libdl.jl:114
    [2] dlopen (repeats 2 times)
      @ ./libdl.jl:114 [inlined]
    [3] __init__()
      @ MbedTLS_jll ~/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/MbedTLS_jll/src/MbedTLS_jll.jl:40
    [4] _include_from_serialized(path::String, depmods::Vector{Any})
      @ Base ./loading.jl:674
    [5] _require_search_from_serialized(pkg::Base.PkgId, sourcepath::String)
      @ Base ./loading.jl:760
    [6] _require(pkg::Base.PkgId)
      @ Base ./loading.jl:998
    [7] require(uuidkey::Base.PkgId)
      @ Base ./loading.jl:914
    [8] require(into::Module, mod::Symbol)
      @ Base ./loading.jl:901
    [9] include
      @ ./Base.jl:386 [inlined]
   [10] macro expansion
      @ ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:24 [inlined]
   [11] macro expansion
      @ /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Test/src/Test.jl:1151 [inlined]
   [12] macro expansion
      @ ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:23 [inlined]
   [13] macro expansion
      @ ./timing.jl:368 [inlined]
   [14] runtests(name::String, path::String, isolate::Bool; seed::UInt128)
      @ Main ~/anaconda3/envs/juliatempenv/share/julia/test/testdefs.jl:21
   [15] (::Distributed.var"#106#108"{Distributed.CallMsg{:call_fetch}})()
      @ Distributed /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278
   [16] run_work_thunk(thunk::Distributed.var"#106#108"{Distributed.CallMsg{:call_fetch}}, print_error::Bool)
      @ Distributed /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:63
   [17] macro expansion
      @ /home/conda/feedstock_root/build_artifacts/julia_1628188098644/work/usr/share/julia/stdlib/v1.6/Distributed/src/process_messages.jl:278 [inlined]
   [18] (::Distributed.var"#105#107"{Distributed.CallMsg{:call_fetch}, Distributed.MsgHeader, Sockets.TCPSocket})()
      @ Distributed ./task.jl:411
  during initialization of module MbedTLS_jll
  in expression starting at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/MbedTLS_jll/test/runtests.jl:3
Error in testset MozillaCACerts_jll:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/MozillaCACerts_jll/test/runtests.jl:7
  Expression: isfile(MozillaCACerts_jll.cacert)
Error in testset NetworkOptions:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/NetworkOptions/test/runtests.jl:5
  Expression: isfile(bundled_ca_roots())
Error in testset PCRE2_jll:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/PCRE2_jll/test/runtests.jl:9
  Expression: vn == v"10.36.0"
   Evaluated: v"10.37.0" == v"10.36.0"
Error in testset SuiteSparse_jll:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/SuiteSparse_jll/test/runtests.jl:6
  Expression: ccall((:SuiteSparse_version, libsuitesparseconfig), Cint, (Ptr{Cint},), C_NULL) == 5004
   Evaluated: 5010 == 5004
Error in testset nghttp2_jll:
Test Failed at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/stdlib/v1.6/nghttp2_jll/test/runtests.jl:14
  Expression: VersionNumber(unsafe_string(info.version_str)) == v"1.41.0"
   Evaluated: v"1.43.0" == v"1.41.0"
ERROR: LoadError: Test run finished with errors
in expression starting at /home/mkitti/anaconda3/envs/juliatempenv/share/julia/test/runtests.jl:84
ERROR: A test has failed. Please submit a bug report (https://github.com/JuliaLang/julia/issues)
including error messages above and the output of versioninfo():
Julia Version 1.6.1
Commit 6aaedecc44* (2021-04-23 05:59 UTC)
Platform Info:
  OS: Linux (x86_64-conda-linux-gnu)
  CPU: AMD FX(tm)-8350 Eight-Core Processor
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-11.0.1 (ORCJIT, bdver1)

Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:33
 [2] runtests(tests::Vector{String}; ncores::Int64, exit_on_error::Bool, revise::Bool, seed::Nothing)
   @ Base ./util.jl:578
 [3] runtests (repeats 2 times)
   @ ./util.jl:563 [inlined]
 [4] top-level scope
   @ REPL[9]:1

@mkitti
Copy link
Contributor

mkitti commented Aug 10, 2021

@isuruf Where do we stand on this pull request? If this is workable for conda-forge, I suggest we make this available and move on to refining the recipe for 1.6.2 where there may be some helpful backported patches.

Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One question.


test:
commands:
- julia -e 'Base.runtests("LibGit2/online Pkg/pkg")'
- julia -e 'Base.runtests(["core", "regex", "Downloads"])'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the previous tests part of the new tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, LibGit2/online Pkg/pkg are not part of the new tests.

The old tests focus only on subsets of the LibGit2 and Pkg stdlib packages. They are actually not included in the default tests except when explicit requested. They were a weird choice for the only tests to run.
https://github.com/JuliaLang/julia/blob/68c458519d369d922e1bfc2c8f9bb240c8718eaa/test/choosetests.jl#L153-L154

Above in a previous comment I ran the standard test suite. It takes some time to run, which has been the subject of complaints in the git history.

The available tests to run are below:

$ make print-TESTS
TESTS=all stdlib unicode strings compiler NetworkOptions Artifacts CompilerSupportLibraries_jll SHA Zlib_jll Statistics Random LibGit2_jll DelimitedFiles Pkg CRC32c Profile OpenBLAS_jll nghttp2_jll OpenLibm_jll SparseArrays LibSSH2_jll p7zip_jll LibCURL_jll InteractiveUtils MPFR_jll MbedTLS_jll LinearAlgebra Distributed Test TOML ArgTools Logging FileWatching UUIDs Libdl Base64 Tar Markdown Sockets GMP_jll Serialization LibGit2 LibCURL Dates LibUnwind_jll Mmap SuiteSparse REPL PCRE2_jll Unicode SuiteSparse_jll libblastrampoline_jll SharedArrays LibUV_jll LLVMLibUnwind_jll libLLVM_jll MozillaCACerts_jll Future Printf LazyArtifacts Downloads dSFMT_jll subarray ambiguous filesystem arrayops read path error float16 precompile stacktraces triplequote iobuffer bitarray client stress corelogging sysinfo exceptions ordering checked loading complex ranges deprecation_exec math binaryplatforms cartesian threads_exec misc ccall sorting syntax goto hashing channels numbers spawn simdloop rational intrinsics subtype reinterpretarray interpreter test_sourcepath secretbuffer int rounding combinatorics opaque_closure euler asyncmap mod2pi parse specificity test_exec boundscheck_exec some choosetests smallarrayshrink worlds backtrace fastmath broadcast meta docs reduce env staged osutils iostream namedtuple show boundscheck core dict download_exec tuple atomics copy download gmp cmdlineargs reducedim floatapprox file atexit reflection abstractarray intfuncs char threads llvmcall2 sets mpfr iterators stress_fd_exec bitset vecelement errorshow generic_map_tests missing operators enums keywordargs functional offsetarray floatfuncs testenv stack_overflow version regex llvmcall ryu unicode/utf8 strings/io strings/util strings/search strings/types strings/basic compiler/inference compiler/validation compiler/interpreter_exec compiler/codegen compiler/contextual compiler/inline compiler/ssair compiler/irpasses

@isuruf isuruf merged commit 2863852 into conda-forge:master Aug 10, 2021
@isuruf
Copy link
Member

isuruf commented Aug 10, 2021

Thanks

@simeonschaub simeonschaub deleted the sds/fix_1.6 branch August 10, 2021 09:40
@mkitti mkitti mentioned this pull request Sep 20, 2021
5 tasks
@mkitti mkitti mentioned this pull request Jan 9, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants