-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.6.2 #99
5.6.2 #99
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- make allshared, remove shared-build patches - handle soname on mac
Windows fails with:
Based on https://github.com/scivision/mumps/blob/44fb7e74b5780a3ea1c26a76a55298a2c34279fe/cmake/mumps.cmake#L62, I guess we just need to remove that file from the CMakeLists.txt (and add some other files that I have been added). @minrk I can directly modify the CMakeLists.txt in your branch if that is ok for you. |
@Traverso thanks for the offer! I've updated the CMakeLists based on a diff of |
not sure what's up here, only seems to fail for osx-arm64
Everything appears to work except mac arm builds, which can't find libgfortran at link time for mysterious reasons:
I copied conda-forge/climlab-feedstock#62 which faced the same error, we'll see if the same fix works. @Traverso can you check if the Windows paths are correct now? I took a stab at #64 and the updated expectations in meta.yaml pass, but I'm not 100% sure I've updated the expectations correctly (DLLs in bin, LIBs in lib). |
Great, thanks! |
Everything seems correct now. Just FYI, since CMake 3.14 the default arguments for |
I'm at a loss on the mac-arm64-nompi builds, which are the only ones failing now. I don't know what else to try. I assume I'm just missing something in the FFLAGS or the right package in build and/or host. |
FL instead of FC, pass LDFLAGS to linker
actually, I do have an idea for possibly missing linker flags on the failing entry |
passing along LDFLAGS may have been enough
Huzzah! 5769967 works. The problem was $LDFLAGS wasn't getting passed along to libpord_seq and libmpi_seq, and adding them fixes things. One more commit to make sure that the addition of |
closes #64
closes #83
closes #98
no longer need our shared-library patches
haven't looked at Windows yet