-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
osx arm fix #62
osx arm fix #62
Conversation
…nda-forge-pinning 2022.02.10.16.19.14
…nda-forge-pinning 2022.03.02.18.03.40
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2022.03.02.18.03.40
locally |
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub actions workflow run https://github.com/conda-forge/climlab-feedstock/actions/runs/1924081051. |
Hi @ngam, fantastic to see the osx_arm builds working here! The pypy failures I've seen before. I really don't know how to begin debugging them since I don't know anything about that platform. But it's not a huge priority for me. The cpython failures here look new. Looks like something went wrong with the Fortran builds. I'll have to dig in to that. |
Sounds good. I will try to look into this locally and see where the errors with pypy are coming from. I will also try to isolate what's going on with the osx cython locally. We will hopefully get this to a good working order soon :) |
The cython errors are all
|
@brian-rose, this is the problematic test for pypy https://github.com/brian-rose/climlab/blob/main/climlab/tests/test_insolation.py If you look at the error closely, I am not really sure it has anything to do with climlab, it may be a pooch error...
I will go ahead and run all tests except this one to see if things go smoothly here. |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender 🤞 this turns them all into green. Skipping that insolation test. |
…nda-forge-pinning 2022.03.02.18.03.40
The cython errors were my fault. I believe I confused it by adding gfortran in host when it wasn't needed for osx-64. The issue with osx-arm was that the build fortran compiler was actually osx-64 since it is cross-compiling and so it didn't play nice. When providing gfortran in host (host is osx-arm in the case of osx-arm), then it plays along for osx-arm. Anyway, hopefully this fixes all of them. I am not sure how much I would bother with debugging the pypy failure. I would just skip that test for now and see if issues arise later. However, that's up to you. I suspect the issue is elsewhere (a different feedstock) |
For pypy, you can also skip that whole framework if you don't think you need it. But it wouldn't hurt just letting it be out there. It seems everything works fine. If you want to test it locally, you can create a pypy env simply by |
To summarize the changes to review before merging:
Everything else should be exactly the same. Note some misc automatic changes happen (e.g. adding impl stuff to enable the python interpreter selector, cpython vs pypy) |
Thanks for sleuthing that out! Odd, because pooch gets called for some other tests too that are passing. I may play around with pypy locally at some point and look at it more carefully, but for now I like your workaround! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic. Thanks so much for this contribution @ngam!
Great! Thank YOU for your work --- it is inspiring :) |
If you care to share your twitter handle, I'll give you a shoutout when I announce that the OSX ARM builds are available! |
I am sleuth there too 😆 (just absorbing info) Btw, I started the issue #63 to track and i think it is clearer now what's going on. I hurriedly thought it would be somewhere else. I am not that familiar with pypy and why it is doing this here, but a solution is to figure out an alternative way to call that line |
seems to have worked in conda-forge/climlab-feedstock#62
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)