-
-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use newest micromamba #199
Conversation
We should setup a Github Action to auto-update that, I can do that soon. |
Thanks @xhochy that would hopefully allow us to catch these errors a bit earlier :( need to look into what's breaking here. |
We had problems building both |
@@ -39,7 +39,7 @@ cp LICENSE "${TEMP_DIR}/" | |||
ls -al "${TEMP_DIR}" | |||
|
|||
if [[ "${TARGET_PLATFORM}" != win-* ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that mamba-org/mamba#961 is fixed, it should be possible to use micromamba on windows too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericpre thanks for the reminder! :)
Are you running Windows? I am building miniforge with micromamba on Windows over here: https://github.com/wolfv/miniforge/actions/runs/1341613621
Artifacts to try should become ready in a couple of minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will try in a virtual machine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working fine: I couldn't see anything wrong with the distribution and the shortcut menu is created. However, there is the following error message:
It may be related to https://github.com/conda/constructor/blob/f14fa91e1e363a029fffccb74c81618d27285bfb/constructor/nsis/main.nsi.tmpl#L904. It is possible that all start menu are created by default and that the menu_packages
option of constructor is ignored. Does micromamba supports the --make-menus
argument?
On this topic, there is conda/constructor#466.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, micromamba doesn't know about this argument yet. It should be quite trivial to add it though!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, sounds good!
Removing menu when uninstalling doesn't work, see https://github.com/conda/constructor/blob/f14fa91e1e363a029fffccb74c81618d27285bfb/constructor/nsis/main.nsi.tmpl#L981
I don't know if other arguments are missing but just in case, the conda-standalone
arguments for constructor
are defined in https://github.com/conda-forge/conda-standalone-feedstock/blob/374ae2c27efcf5fd5cd38ddea316f59ff242067f/recipe/entry_point.py#L30-L51
I think the most important part is to add a test to |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)