Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use newest micromamba #199

Merged
merged 4 commits into from
Oct 14, 2021
Merged

use newest micromamba #199

merged 4 commits into from
Oct 14, 2021

Conversation

wolfv
Copy link
Member

@wolfv wolfv commented Aug 13, 2021

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@wolfv wolfv requested a review from a team as a code owner August 13, 2021 09:41
@xhochy
Copy link
Member

xhochy commented Aug 13, 2021

We should setup a Github Action to auto-update that, I can do that soon.

@wolfv
Copy link
Member Author

wolfv commented Aug 13, 2021

Thanks @xhochy that would hopefully allow us to catch these errors a bit earlier :( need to look into what's breaking here.

@wolfv
Copy link
Member Author

wolfv commented Oct 14, 2021

We had problems building both mamba and micromamba on PPC64LE unfortunately.

@@ -39,7 +39,7 @@ cp LICENSE "${TEMP_DIR}/"
ls -al "${TEMP_DIR}"

if [[ "${TARGET_PLATFORM}" != win-* ]]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that mamba-org/mamba#961 is fixed, it should be possible to use micromamba on windows too?

This was disabled in #160, because of #158.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericpre thanks for the reminder! :)

Are you running Windows? I am building miniforge with micromamba on Windows over here: https://github.com/wolfv/miniforge/actions/runs/1341613621

Artifacts to try should become ready in a couple of minutes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try in a virtual machine.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working fine: I couldn't see anything wrong with the distribution and the shortcut menu is created. However, there is the following error message:

Screenshot from 2021-10-14 13-49-30
It may be related to https://github.com/conda/constructor/blob/f14fa91e1e363a029fffccb74c81618d27285bfb/constructor/nsis/main.nsi.tmpl#L904. It is possible that all start menu are created by default and that the menu_packages option of constructor is ignored. Does micromamba supports the --make-menus argument?

On this topic, there is conda/constructor#466.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, micromamba doesn't know about this argument yet. It should be quite trivial to add it though!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, sounds good!
Removing menu when uninstalling doesn't work, see https://github.com/conda/constructor/blob/f14fa91e1e363a029fffccb74c81618d27285bfb/constructor/nsis/main.nsi.tmpl#L981

I don't know if other arguments are missing but just in case, the conda-standalone arguments for constructor are defined in https://github.com/conda-forge/conda-standalone-feedstock/blob/374ae2c27efcf5fd5cd38ddea316f59ff242067f/recipe/entry_point.py#L30-L51

@isuruf
Copy link
Member

isuruf commented Oct 14, 2021

Thanks @xhochy that would hopefully allow us to catch these errors a bit earlier :( need to look into what's breaking here.

I think the most important part is to add a test to mamba-org/mamba repo to check that building an installer is supported. That way, errors are caught before the PRs are merged in mamba repo, instead of catching errors after they are pushed into mamba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants