Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull pcre2 from conda-forge #9

Merged
merged 3 commits into from
Sep 13, 2017

Conversation

dfornika
Copy link
Contributor

Addresses #1.

@jakirkham
Copy link
Member

Would raise this upstream and see if they have any suggestions.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

Toggling for CIs.

@jakirkham jakirkham closed this Sep 13, 2017
@jakirkham jakirkham reopened this Sep 13, 2017
@jakirkham jakirkham closed this Sep 13, 2017
@jakirkham jakirkham reopened this Sep 13, 2017
@jakirkham
Copy link
Member

Have you ever seen this error, @tkelman? Are there some other options we need to be using when building pcre2?

LoadError("sysimg.jl",152,LoadError("show.jl",1238,ErrorException("PCRE JIT error: bad JIT option")))
*** This error is usually fixed by running `make clean`. If the error persists, try `make cleanall`. ***
make[2]: *** [/feedstock_root/build_artefacts/julia_1505267137273/work/julia-0.5.2/usr/lib/julia/sys.o] Error 1
make[1]: *** [julia-sysimg-release] Error 2
make[1]: *** Waiting for unfinished jobs....

@jakirkham
Copy link
Member

jakirkham commented Sep 13, 2017

I think we forgot the --enable-jit option when building pcre2. Will look at adding a PR.

Edit: Please see PR ( conda-forge/pcre2-feedstock#6 ).

@jakirkham jakirkham closed this Sep 13, 2017
@jakirkham jakirkham reopened this Sep 13, 2017
@dfornika dfornika merged commit 6a8f275 into conda-forge:v0.5 Sep 13, 2017
@jakirkham
Copy link
Member

🎉

@dfornika
Copy link
Contributor Author

I think we've got to bump the build number on this too. 0.5.2-1 was the build that removed the wrapper script, so this should be 0.5.2-2

@jakirkham
Copy link
Member

Right. Do you want to do this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants