Pull pcre2 from conda-forge #1
Comments
|
Should be good to go now. Though it might be worthwhile to check on how it need to be pinned. |
|
It probably doesn't, as long as it's pcre2. This has been our least problematic dependency over time. |
|
The pinning is to make sure that we have a version range that is not breaking things. They have changed the SONAME a couple of times FWICT. |
|
We load the unversioned so I believe. I can't recall pcre ever making a change that broke anything on the Julia side, other than minor little build issues. |
This was referenced Sep 9, 2017
jakirkham
added a commit
to jakirkham-feedstocks/julia-feedstock
that referenced
this issue
Sep 12, 2017
* Add a custom juliarc.jl Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment. * Install custom juliarc Make sure that that our custom juliarc is available in the standard location. * Create the package directory Make sure that Julia initializes our package directory and includes the standard packages in it. * Bump build number to 1 Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory.
dfornika
added a commit
that referenced
this issue
Sep 13, 2017
* Removed wrapper script * Bumped build number * Use juliarc (#1) * Add a custom juliarc.jl Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment. * Install custom juliarc Make sure that that our custom juliarc is available in the standard location. * Create the package directory Make sure that Julia initializes our package directory and includes the standard packages in it. * Bump build number to 1 Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory. * Removed JULIA_HISTORY setting * Drop package initialization (#2) This does not work correctly as `conda-build` strips out the `.git` directory from `METADATA`. There are no clean fixes for this issue. As we already try to initialize the package directory when Julia starts, this will be handled anyways on the user's machine. In the end, this may be best to avoid having a potentially out-of-date index in the package. * Append juliarc.jl instead of replace * Append juliarc.jl the right way * Added post-link script for Pkg.init() * Removed Pkg.init() from juliarc.jl * Correct setting Base.LOAD_CACHE_PATH * Correct setting Base.LOAD_CACHE_PATH again
jakirkham
pushed a commit
to jakirkham-feedstocks/julia-feedstock
that referenced
this issue
Sep 13, 2017
* Removed wrapper script * Bumped build number * Use juliarc (conda-forge#1) * Add a custom juliarc.jl Needed to ensure packages and other relevant information to the Julia install are tracked in the conda environment. * Install custom juliarc Make sure that that our custom juliarc is available in the standard location. * Create the package directory Make sure that Julia initializes our package directory and includes the standard packages in it. * Bump build number to 1 Needed to repackage after removal of the wrapper script, inclusion of juliarc, and inclusion of the prepopulated package directory. * Removed JULIA_HISTORY setting * Drop package initialization (conda-forge#2) This does not work correctly as `conda-build` strips out the `.git` directory from `METADATA`. There are no clean fixes for this issue. As we already try to initialize the package directory when Julia starts, this will be handled anyways on the user's machine. In the end, this may be best to avoid having a potentially out-of-date index in the package. * Append juliarc.jl instead of replace * Append juliarc.jl the right way * Added post-link script for Pkg.init() * Removed Pkg.init() from juliarc.jl * Correct setting Base.LOAD_CACHE_PATH * Correct setting Base.LOAD_CACHE_PATH again (cherry picked from commit 19d96fa)
|
Done in PR ( #9 ). |
|
Related question, does Julia actually link to PCRE2 or does it just use it as part of the build process? Asking as I'm not seeing any linkages when inspecting Julia, but I could just be missing something. |
|
It's dynamically loaded and used at runtime (and build time as well). |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When pcre2 has been accepted into conda-forge, add it as a build-time and run-time requirement
conda-forge/staged-recipes#3656
The text was updated successfully, but these errors were encountered: