-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oneTBB, oneMKL, oneDAL, MPI and OpenMP versions #82
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
|
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.30.09.36.02
…, and conda-forge-pinning 2024.10.30.09.36.02" This reverts commit e320285.
Waiting for 2022 version of oneTBB in conda-forge (https://github.com/conda-forge/tbb-feedstock) |
Thank you @Alexsandruss ! There is also I guess I'll update it just for now so it produces But we need to wait for conda-forge/intel-compiler-repack-feedstock#52 |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.10.31.23.25.38
…, and conda-forge-pinning 2024.10.31.23.25.38" This reverts commit 3702036.
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.11.05.21.36.17
I'm working on this PR right now. I've fixed build locally and currently working on proper dependencies. |
…nda-forge-pinning 2024.11.06.14.03.29
Do not merge yet, still working on it |
Hmm,
On windows we are out of space... |
One thing we've just discussed with @oleksandr-pavlyk is that neither openmp, neither tbb are required in mkl. It's up to end user to chose what dependencies they want to use. So we would want to move it to separate discussion to remove it from mkl dependency. In a meantime. I've accidentally added openmp mutex to all |
LGMT! But I would wait for @oleksandr-pavlyk approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions here, I believe some things may have gone wrong. PTAL @ZzEeKkAa @Alexsandruss
build: | ||
- {{ compiler('c') }} | ||
- {{ compiler('cxx') }} | ||
- {{ c_stdlib }}_{{ target_platform }} >={{ c_stdlib_sycl_version }} # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use >=
at build time, but pin to a specific version that you need. This is because the version of sysroot_linux
at build time will create a corresponding runtime requirement. For example, the current MKL 2025.0 builds are not installable on a linux system with __glibc <2.28
anymore. Is that intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is intentional for onemkl-sycl-*
packages because sycl runtime/compiler requires glibc >= 2.28. Here it looks like I've accidentally set sycl like requirement on the glibc version
# sycl runtime components depends on 2.28 glibc. | ||
c_stdlib_sycl_version: # [linux] | ||
- 2.28 # [linux] | ||
c_stdlib_version: # [linux] | ||
- 2.17 # [linux] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In particular, I don't understand why the sycl components would affect MKL? And if it's just for building, then it should be enough to bump the image version, but leave c_stdlib_version
untouched.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)