Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oneTBB, oneMKL, oneDAL, MPI and OpenMP versions #82

Merged
merged 15 commits into from
Nov 8, 2024

Conversation

Alexsandruss
Copy link
Contributor

@Alexsandruss Alexsandruss commented Oct 30, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Oct 30, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found some lint.

Here's what I've got...

For recipe/meta.yaml:

  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • When defining a source/url please add a sha256, sha1 or md5 checksum (sha256 preferably).
  • Jinja2 variable definitions are suggested to take a {%<one space>set<one space><variable name><one space>=<one space><expression><one space>%} form. See lines [46, 51]

@Alexsandruss
Copy link
Contributor Author

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits October 30, 2024 10:39
…, and conda-forge-pinning 2024.10.30.09.36.02"

This reverts commit e320285.
@Alexsandruss
Copy link
Contributor Author

Waiting for 2022 version of oneTBB in conda-forge (https://github.com/conda-forge/tbb-feedstock)

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Oct 30, 2024

Thank you @Alexsandruss !

There is also intel-pti package added with this release, but I have scripts to build it from source:
conda-forge/pti-gpu-unitrace-feedstock#1

I guess I'll update it just for now so it produces intel-pti without split.

But we need to wait for conda-forge/intel-compiler-repack-feedstock#52

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 1, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 3 commits November 1, 2024 18:27
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 6, 2024

@conda-forge-admin, please rerender

conda-forge-webservices[bot] and others added 2 commits November 6, 2024 02:49
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 6, 2024

I'm working on this PR right now. I've fixed build locally and currently working on proper dependencies.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 7, 2024

Do not merge yet, still working on it

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 7, 2024

Hmm,

024-11-07T00:51:59.0898228Z Traceback (most recent call last):
2024-11-07T00:51:59.0900327Z   File "D:\Miniforge\Scripts\conda-build-script.py", line 10, in <module>
2024-11-07T00:51:59.0908273Z     sys.exit(execute())
2024-11-07T00:51:59.0909693Z              ^^^^^^^^^
2024-11-07T00:51:59.0910660Z   File "D:\Miniforge\Lib\site-packages\conda_build\cli\main_build.py", line 589, in execute
2024-11-07T00:51:59.0927579Z     api.build(
2024-11-07T00:51:59.0928734Z   File "D:\Miniforge\Lib\site-packages\conda_build\api.py", line 209, in build
2024-11-07T00:51:59.0935634Z     return build_tree(
2024-11-07T00:51:59.0936360Z            ^^^^^^^^^^^
2024-11-07T00:51:59.0937291Z   File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3670, in build_tree
2024-11-07T00:51:59.1012625Z     test(pkg, config=metadata.config.copy(), stats=stats)
2024-11-07T00:51:59.1013833Z   File "D:\Miniforge\Lib\site-packages\conda_build\build.py", line 3422, in test
2024-11-07T00:51:59.1024978Z     environ.create_env(
2024-11-07T00:51:59.1025938Z   File "D:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1050, in create_env
2024-11-07T00:51:59.1051828Z     _execute_actions(prefix, precs)
2024-11-07T00:51:59.1052876Z   File "D:\Miniforge\Lib\site-packages\conda_build\environ.py", line 1338, in _execute_actions
2024-11-07T00:51:59.1062982Z     progressive_fetch_extract.execute()
2024-11-07T00:51:59.1064083Z   File "D:\Miniforge\Lib\site-packages\conda\core\package_cache_data.py", line 900, in execute
2024-11-07T00:51:59.1086495Z     raise CondaMultiError(not_cancelled)
2024-11-07T00:51:59.1087261Z conda.CondaMultiError: [Errno 28] No space left on device
2024-11-07T00:51:59.1087963Z [Errno 28] No space left on device
2024-11-07T00:51:59.1088463Z 

On windows we are out of space...

@Alexsandruss Alexsandruss marked this pull request as ready for review November 7, 2024 23:01
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 7, 2024

One thing we've just discussed with @oleksandr-pavlyk is that neither openmp, neither tbb are required in mkl. It's up to end user to chose what dependencies they want to use. So we would want to move it to separate discussion to remove it from mkl dependency. In a meantime. I've accidentally added openmp mutex to all onemkl-sycl-* packages. I need to fix it before merge.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented Nov 7, 2024

LGMT! But I would wait for @oleksandr-pavlyk approval.

@Alexsandruss Alexsandruss merged commit e640606 into conda-forge:main Nov 8, 2024
10 of 11 checks passed
Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions here, I believe some things may have gone wrong. PTAL @ZzEeKkAa @Alexsandruss

build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
- {{ c_stdlib }}_{{ target_platform }} >={{ c_stdlib_sycl_version }} # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use >= at build time, but pin to a specific version that you need. This is because the version of sysroot_linux at build time will create a corresponding runtime requirement. For example, the current MKL 2025.0 builds are not installable on a linux system with __glibc <2.28 anymore. Is that intentional?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is intentional for onemkl-sycl-* packages because sycl runtime/compiler requires glibc >= 2.28. Here it looks like I've accidentally set sycl like requirement on the glibc version

Comment on lines +1 to +5
# sycl runtime components depends on 2.28 glibc.
c_stdlib_sycl_version: # [linux]
- 2.28 # [linux]
c_stdlib_version: # [linux]
- 2.17 # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In particular, I don't understand why the sycl components would affect MKL? And if it's just for building, then it should be enough to bump the image version, but leave c_stdlib_version untouched.

recipe/meta.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants