Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build for MKL 2025.0 #128

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

build for MKL 2025.0 #128

wants to merge 4 commits into from

Conversation

h-vetinari
Copy link
Member

@h-vetinari h-vetinari commented Nov 8, 2024

Not having this pushes the solver into weird contortions like

- libblas                            3.9.0  25_win64_mkl           conda-forge        4MB
+ libblas                            3.9.0  25_win64_openblas      conda-forge        4MB
- libcblas                           3.9.0  25_win64_mkl           conda-forge        4MB
+ libcblas                           3.9.0  25_win64_openblas      conda-forge        4MB
- liblapack                          3.9.0  25_win64_mkl           conda-forge        4MB
+ liblapack                          3.9.0  25_win64_openblas      conda-forge        4MB

because it ends up prioritizing the newer MKL; apparently despite the track_features on the non-default BLAS impl here.

We might want to add more track_features here?

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

This runs into problems due to conda-forge/libhwloc-feedstock#83 and (I think) wrong metadata in conda-forge/intel_repack-feedstock#82 (that is, unless MKL now requires 2.28 everywhere)

@ZzEeKkAa
Copy link

@conda-forge-admin rerender

@ZzEeKkAa
Copy link

win64 mkl build is still failing(

@ZzEeKkAa
Copy link

@mkrainiuk could you take a look?

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12878584559. Examine the logs at this URL for more detail.

@h-vetinari
Copy link
Member Author

Did some digging where the use of mkl_rt comes from - it's been there since the very beginning of windows support: bf90dd3

Furthermore, the MKL docs indicate that this should still work. I've asked again in conda-forge/intel_repack-feedstock#83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants