Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CUDA 12 w/arch + Windows support #99

Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! 🙏


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/6895753873, please use this URL for debugging.

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and
build tools. Notably, the cudatoolkit package no longer exists, and packages
should depend directly on the specific CUDA libraries (libcublas, libcusolver,
etc) as needed. For an in-depth overview of the changes and to report problems
[see this issue]( conda-forge/conda-forge.github.io#1963 ).
Please feel free to raise any issues encountered there. Thank you! 🙏
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jakirkham
Copy link
Member

It looks like something odd is going on with spdlog

@benfred could you please take a look?

@benfred
Copy link
Contributor

benfred commented Nov 17, 2023

@jakirkham - I'm seeing errors like

2023-11-16T20:46:39.3470001Z   /home/conda/feedstock_root/build_artifacts/implicit_1700167350983/work/_skbuild/linux-x86_64-3.10/cmake-build/_deps/spdlog-src/include/spdlog/common.h:168:111: error: 'basic_runtime' is not a member of 'fmt'

in the log here - which seems to be because of a version incompatibility between spdlg 1.11 and fmt 10 gabime/spdlog#2767 (comment) .

It seems like we're picking up this package combination here though rapids-cmake

2023-11-16T20:45:47.5488030Z   -- CPM: rmm: using local package fmt@10.1.0
2023-11-16T20:45:47.5669672Z   -- CPM: rmm: adding package spdlog@1.11.0 (v1.11.0)

@bdice I see that you're testing out fmt10/spdlog 1.12 (which afaict shouldn't have this issue) in raft rapidsai/raft#1957 - do you have any thoughts on this issue?

@jakirkham
Copy link
Member

Thanks Ben! 🙏

Should we be adding these as dependencies?

recipe/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben! 🙏

Should we add spdlog too? Is there anything else we should add?

recipe/meta.yaml Show resolved Hide resolved
@bdice
Copy link

bdice commented Nov 19, 2023

@benfred @jakirkham Yes, upgrading to fmt 10 / spdlog 1.12 is needed to keep RAPIDS aligned with conda-forge. I am planning to target this update for 24.02. Please see this thread for the discussion of fmt/spdlog updates in rapids-cmake: rapidsai/rapids-cmake#473 (comment)

benfred and others added 2 commits November 21, 2023 09:25
Co-authored-by: jakirkham <jakirkham@gmail.com>
@benfred benfred merged commit 75d9bd0 into conda-forge:main Nov 21, 2023
91 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the rebuild-cuda120-0-3_h673e1b branch November 21, 2023 19:07
@jakirkham
Copy link
Member

Thanks Ben and Bradley! 🙏

JFYI bumped the build/number in main with commit: 3832f65

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants