Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility issue with fmt 10.0.0 #2767

Closed
tpadioleau opened this issue Jun 17, 2023 · 6 comments
Closed

Compatibility issue with fmt 10.0.0 #2767

tpadioleau opened this issue Jun 17, 2023 · 6 comments

Comments

@tpadioleau
Copy link

Installing spdlog through spack 0.20.0, spdlog 1.11.0 does not seem compatible with fmt 10.0.0. I got the following error

spack-stage/spack-stage-spdlog-1.11.0-zvauaorbv4tdtysvbukpjevw7lfciqbh/spack-src/include/spdlog/common.h:168:111
            : error: 'basic_runtime' is not a member of 'fmt'

Should the spack recipe be updated accordingly ?

@gabime
Copy link
Owner

gabime commented Jun 17, 2023

Latest commit of spdlog should work with fmt 10

@tpadioleau
Copy link
Author

Thanks for the update.

What do you think of the spack recipe ? It seems to me spdlog 1.11 is only compatible with fmt 9.

@gabime
Copy link
Owner

gabime commented Jun 18, 2023

Yes thats right. 1.11 doesn't support fmt 10

@tpadioleau
Copy link
Author

I just found this MR spack/spack#38082. Maybe we can close this issue then.

@aengusjiang
Copy link
Contributor

just replace basic_runtime with runtime_format_string, then it can compile through.

@xvitaly
Copy link
Contributor

xvitaly commented Jun 27, 2023

@gabime Can you draft a new release of spdlog with fmt 10.0 compatibility?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants