unpin netcdf4 to free and bump build number to 1 #51
Conversation
valeriupredoi
requested review from
bouweandela,
nielsdrost,
schlunma,
sloosvel and
zklaus
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
@conda-forge-admin, please rerender |
|
@bouweandela @zklaus we're in trouble with mypy, like we were a week ago in the main dev repo - we fixed the behaviour in the main dev repo, but the package build is failing here - what you guys recommend? I'd pin mypy if it was me 👍 |
|
what do people think then? It could be that we may want to have us a bugfix release as well - given that a number of pins have now been relaxed (am also gonna open a PR to relax flake8 too) - @conda-forge/esmvalcore |
|
OK - I updated the environment: to be able to have the tests run and package be built I had to pin mypy plugin, I also released the pin on flake8 as we did in Core just recently |
|
mypy fails are getting a bit too hard to solve - any recommendations here guys? Or, I can just close this since we can wait for the release to get all the pins one line? |
|
You'll probably want to pin mypy instead of the pytest plugin used to run it. |
I believe you are absolutely correct @bouweandela - let me try that now 👍 |
|
finally 🟢 @bouweandela can we get this in? I will open an issue with the different pins that we'll have to fix at release point after we merge (also I think we need to add @remi-kazeroni to the repo, if he's gonna be our next RM) 🍺 |
|
huzzah! Cheers @bouweandela 🍻 |
Checklist
conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)We repo patched iris to force the pin netCDF4<1.6.1 across versions, so our pin is now redundant. We have done the same in the dev repo ESMValGroup/ESMValCore#1814
To be able to have the tests run and package be built I had to pin mypy plugin, I also released the pin on flake8 as we did in Core just recently.