Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin NetCF4 #1814

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Unpin NetCF4 #1814

merged 4 commits into from
Nov 21, 2022

Conversation

valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Nov 21, 2022

Description

Unpin NetCDF4 because this pin was needed because of an iris issue that has now been taken care of by iris.

Ongoing efforts to avoid effects described in #1727 (do not kill that issue BTW, it's needed to have contact with iris folks until things get sorted out correctly on their side). Done the same in Tool ESMValGroup/ESMValTool#2929


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #1814 (4d8cd38) into main (9a2a318) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1814   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files         202      202           
  Lines       10908    10908           
=======================================
  Hits         9980     9980           
  Misses        928      928           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela changed the title Unpin netcdf4 to free since we repo patched iris with <1.6.1 pin Unpin NetCF4 Nov 21, 2022
Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@valeriupredoi
Copy link
Contributor Author

cheers Bouwe! Can one of the @ESMValGroup/technical-lead-development-team pls merge 🍻

@remi-kazeroni
Copy link
Contributor

Thanks @valeriupredoi and @bouweandela!

@remi-kazeroni remi-kazeroni merged commit 96419a7 into main Nov 21, 2022
@remi-kazeroni remi-kazeroni deleted the unpin_netcdf4 branch November 21, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installation Installation problem testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants