Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove commas in version-ranges #954

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Remove commas in version-ranges #954

merged 2 commits into from
Dec 4, 2018

Conversation

climblinne
Copy link
Contributor

@climblinne climblinne commented Nov 26, 2018 •
edited by jgsogo
Loading

Connect to #953 & conan-io/conan#3964

Closes #953

danimtb
danimtb reviewed Nov 27, 2018
View reviewed changes
Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. I'd like to have a more complex "version range" in an example. Something like >0.8 < 1.2 || 1.1 and explain that it will revolve to the max satisfying version in case of a multiple match

mastering/version_ranges.rst Outdated Show resolved Hide resolved
@climblinne
Copy link
Contributor Author

@danimtb Added a more complex range

@danimtb danimtb added this to the 1.10 milestone Dec 4, 2018
@jgsogo jgsogo merged commit a5031d8 into conan-io:master Dec 4, 2018
@ghost ghost removed the stage: review label Dec 4, 2018
@climblinne climblinne deleted the patch-3 branch December 4, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danimtb danimtb danimtb approved these changes

Assignees

@jgsogo jgsogo

Labels
None yet
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@climblinne @danimtb @jgsogo