Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commas in version-ranges make input invalid (breaking) #3964

Closed
jgsogo opened this issue Nov 20, 2018 · 6 comments
Closed

Commas in version-ranges make input invalid (breaking) #3964

jgsogo opened this issue Nov 20, 2018 · 6 comments

Comments

@jgsogo
Copy link
Contributor

jgsogo commented Nov 20, 2018

I'm trying things here (https://semver.npmjs.com/) and in fact, commas are never used (we remove them in our code). Anyway, we should keep the possibility of having one comma (it is documented), but remove it for Conan 2.0.

For <2.0, it would be enough to remove those commas from the documentation: https://docs.conan.io/en/latest/mastering/version_ranges.html

Originally posted by @jgsogo in #3898

@jgsogo
Copy link
Contributor Author

jgsogo commented Nov 20, 2018

Without commas, the string within the [...] will be the straightforward input to node-semver package (take into account, the proposed options strict/loose and include_prerelease in #3898).

Are you agree with it, @conan-io/barbarians?

  1. Remove from docs those commas
  2. Remove in Conan 2.0 the replacement of commas by blanks

@memsharded
Copy link
Member

Yes, remove them as soon as possible from the docs.

Then, introduce a deprecation warning, telling users to remove comas.

@climblinne
Copy link
Contributor

Updated documentation by removing commas.

@climblinne
Copy link
Contributor

Look into 13defc0. Would this message be fine?

@jgsogo jgsogo added this to the 2.0 milestone Dec 4, 2018
@jgsogo
Copy link
Contributor Author

jgsogo commented Dec 4, 2018

Version ranges with commas will be invalid in v2.0 and will throw an exception.

@jgsogo jgsogo changed the title Remove commas in version-ranges Commas in version-ranges make input invalid (breaking) Dec 31, 2018
@memsharded
Copy link
Member

Version ranges in develop2 no longer use comma to separate conditions (they still use commas to separate the include-prerelease part)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants