Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conan-io/docs#2003
#8375
conan-io/conan-center-index#4261
I think I have found a serious bug in the newly added
validate
function:fPIC
andshared
shared=False
is default,fPIC=True
is defaultfPIC
is removed forshared=False
inconfig_options
(according to the https://docs.conan.io/en/latest/mastering/conditional.html?highlight=conditional)dep:shared=True
dep:shared == True
- OKdep:fPIC == True
- raises!now we see that validates incorrectly computes value of
fPIC
option and shows a following error message:this is incorrect, since
dep:shared=True
,fPIC
option existsUPD1: validates works correctly if the option is removed in
configure
instead ofconfig_options
.UPD2: validates also works incorrectly if the option is overridden from the command line (
-o dep:shared=True
)Changelog: (Feature | Fix | Bugfix): Describe here your pull request
Docs: https://github.com/conan-io/docs/pull/XXXX
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.